CBL-7602: Don't use global include_directories (#2390)

Found two instances of global include_directories, one in lite-core/CMakeLists.txt and the other in lite-core/cmake/platform_linux_desktop.cmake. Replacing them with target_include_directories.

Backport from CBL 7203

Author: jianminzhao

CMakeLists.txt

@@ -175,7 +175,6 @@ set(MBEDTLS_FATAL_WARNINGS OFF CACHE INTERNAL "") # Work around doc-comment synt
 add_subdirectory(vendor/mbedtls             EXCLUDE_FROM_ALL)
 
 configure_file(cmake/config_thread.h.in ${GENERATED_HEADERS_DIR}/config_thread.h)
-include_directories(${GENERATED_HEADERS_DIR})
 
 add_subdirectory(Networking/BLIP            EXCLUDE_FROM_ALL)
 
@@ -189,7 +188,9 @@ endif()
 # Separate library to make possible replace or not use
 # during static linking
 add_library(CouchbaseSqlite3 STATIC LiteCore/Storage/SQLiteChooser.c)
-target_include_directories(CouchbaseSqlite3 PUBLIC vendor/SQLiteCpp/sqlite3)
+target_include_directories(CouchbaseSqlite3 PUBLIC vendor/SQLiteCpp/sqlite3
+  PRIVATE ${GENERATED_HEADERS_DIR}
+)
 target_compile_definitions(
   CouchbaseSqlite3
   PUBLIC
@@ -278,10 +279,12 @@ set(
 
 target_include_directories(
     LiteCoreObjects PRIVATE
+    ${GENERATED_HEADERS_DIR}
     ${LiteCoreObjectsIncludes}
 )
 target_include_directories(
     LiteCoreUnitTesting PRIVATE
+    ${GENERATED_HEADERS_DIR}
     ${LiteCoreObjectsIncludes}
 )
 
@@ -319,6 +322,7 @@ if(LITECORE_BUILD_SHARED)
         LiteCore INTERFACE
         C/include
         C/Cpp_include
+        PRIVATE ${GENERATED_HEADERS_DIR}
     ) 
     target_link_libraries(LiteCore PRIVATE ${LITECORE_LIBRARIES_PRIVATE})
 
@@ -396,6 +400,7 @@ set(
 add_library(LiteCoreWebSocket STATIC EXCLUDE_FROM_ALL ${LC_WEBSOCKET_SRC})
 target_include_directories(
     LiteCoreWebSocket PRIVATE
+    ${GENERATED_HEADERS_DIR}
     C
     C/include
     C/Cpp_include

cmake/platform_linux_desktop.cmake

@@ -59,11 +59,10 @@ function(setup_globals)
     if (NOT ZLIB_INCLUDE)
         message(FATAL_ERROR "libz header files not found")
     endif()
-    include_directories(${ZLIB_INCLUDE})
     message("Using libz header files in ${ZLIB_INCLUDE}")
 
     mark_as_advanced(
-           ZLIB_LIB ZLIB_INCLUDE
+        ZLIB_LIB ZLIB_INCLUDE
     )
 endfunction()
 
@@ -99,6 +98,7 @@ function(setup_litecore_build)
            ${liteCoreVariant} INTERFACE
            Threads::Threads
         )
+        target_include_directories(${liteCoreVariant} PRIVATE ${ZLIB_INCLUDE})
     endforeach()
 
     if(NOT LITECORE_DISABLE_ICU AND NOT LITECORE_DYNAMIC_ICU)