You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Fix clippy::needless-doctest-main
Recently released Clippy 1.40 ships with this lint enabled by default.
Since we run with "warnings as errors" policy, this lint causes build
failures which is not nice.
error: needless `fn main` in doctest
--> src/wrappers/themis/rust/libthemis-src/src/lib.rs:37:4
|
37 | //! fn main() {
| ^^^^^^^^^^^^
|
= note: `-D clippy::needless-doctest-main` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main
error: aborting due to previous error
I wouldn't say that explicit main() here is needless and some people
share the same sentiment [1]. However, since this is top-level module
docs, we cannot disable this lint for this place specifically without
turning it off in the entire module. Okay, Clippy, you win.
[1]: rust-lang/rust-clippy#4858
* Fix Cargo with "--features"
No idea what changed here, but for some reason Cargo does not allow to
use "--features" with virtual crates now. However, it has no issues with
it once we're in "themis" crate subdirectory and ask to document all
crates in the workspace anyway.
Apparently, "--features" was not supposed to work with workspaces in the
first place [1], but I have no clue it worked before.
[1]: rust-lang/cargo#5015
0 commit comments