Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max size of packets #7629

Open
gjermundgaraba opened this issue Dec 7, 2024 · 1 comment
Open

Limit max size of packets #7629

gjermundgaraba opened this issue Dec 7, 2024 · 1 comment
Labels
feat: ibc-eureka needs discussion Issues that need discussion before they can be worked on

Comments

@gjermundgaraba
Copy link
Contributor

Version, encoding and payload currently have no size limits. This could lead to very large transactions if a chain does not have a very restrictive global limits (most don't) if abused. This should ideally been solved on the SDK level, but the current global limits there are very high, and we can't rely on those for the time being.

Points that needs discussion:

  • Do we want/need a limit on packet size?
  • Is "global" packet size the best place to add such a limit?
  • What should the limit be?
  • If we do this, should it only be for V2 packets?
@gjermundgaraba gjermundgaraba added the needs discussion Issues that need discussion before they can be worked on label Dec 7, 2024
@github-project-automation github-project-automation bot moved this to Backlog in IBC-GO Eureka Dec 7, 2024
@DimitrisJim
Copy link
Contributor

Ref relevant spec issue cosmos/ibc#1160

(though spec would in theory only mention implementations could opt to add limits, so hashing out what these look like is ibc-go level discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ibc-eureka needs discussion Issues that need discussion before they can be worked on
Projects
Status: Backlog
Development

No branches or pull requests

3 participants