Skip to content

feat(server): add support for SafetyStartDelay to mitigate double-sign risks #25627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meetrick wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −0
Open

feat(server): add support for SafetyStartDelay to mitigate double-sign risks #25627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80c70f4
feat(server): implement O_SYNC toggle and safety start delay
meetrick Dec 1, 2025
95840bf
feat(server): add SafetyStartDelay for double-sign protection
meetrick Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,24 @@ is performed. Note, when enabled, gRPC will also be automatically enabled.
RunE: func(cmd *cobra.Command, _ []string) error {
serverCtx := GetServerContextFromCmd(cmd)

// Logic: Safety Delay is only active when O_SYNC is disabled.
// Use Viper to read config safely (decoupled from CometBFT struct changes)
disableOSSync := serverCtx.Viper.GetBool("disable_os_sync")

if disableOSSync {
// We don't call ForceSync here anymore to avoid dependency on CometBFT changes.
// CometBFT node initialization will handle the actual O_SYNC toggling.

// Apply Safety Start Delay only when O_SYNC is disabled
// Also read from Viper for safety
startDelayStr := serverCtx.Viper.GetString("safety_start_delay")
startDelay, err := time.ParseDuration(startDelayStr)
if err == nil && startDelay > 0 {
serverCtx.Logger.Info("Safety Start Delay active due to disabled O_SYNC", "duration", startDelay)
time.Sleep(startDelay)
}
}

_, err := GetPruningOptionsFromFlags(serverCtx.Viper)
if err != nil {
return fmt.Errorf("failed to get pruning options: %w", err)
Expand Down