Skip to content

Duplication code #1524

@happylolonly

Description

@happylolonly

Hi, why need such funcs?
https://github.com/cosmos/cosmjs/blob/v0.32.0/packages/stargate/src/stargateclient.ts#L333

It is not possible to just use them from inherited modules, than make public?

In our project our devs made same, and code looks duplicated https://github.com/cybercongress/soft3.js/blob/main/src/cyberclient.ts#L430

Or you can do:
public getAllBalances = this.forceGetQueryClient().bank.allBalances;
it will be shorter, and keep types correct.

What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions