Ruler: Prevent counting 2xx responses as failed writes (#6785)

* Prevent counting 2xx responses as failed writes

Signed-off-by: Anand Rajagopal <[email protected]>

* Adding changelog

Signed-off-by: Anand Rajagopal <[email protected]>

---------

Signed-off-by: Anand Rajagopal <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Co-authored-by: Ben Ye <[email protected]>

Author: rajagopalanand

CHANGELOG.md

@@ -51,6 +51,7 @@
 * [BUGFIX] Add `__markers__` tenant ID validation. #6761
 * [BUGFIX] Ring: Fix nil pointer exception when token is shared. #6768
 * [BUGFIX] Fix race condition in active user. #6773
+* [BUGFIX] Ruler: Prevent counting 2xx and 4XX responses as failed writes. #6785
 * [BUGFIX] Ingester: Allow shipper to skip corrupted blocks. #6786
 
 ## 1.19.0 2025-02-27

pkg/ruler/compat.go

@@ -96,7 +96,7 @@ func (a *PusherAppender) Commit() error {
 	_, err := a.pusher.Push(user.InjectOrgID(a.ctx, a.userID), req)
 	if err != nil {
 		// Don't report errors that ended with 4xx HTTP status code (series limits, duplicate samples, out of order, etc.)
-		if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok || resp.Code/100 != 4 {
+		if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok || resp.Code/100 == 5 {
 			a.failedWrites.Inc()
 		}
 	}