Skip to content

Commit b44dc01

Browse files
authored
Remove experimental tag on WAL (#2560)
* Remove experimental tag on WAL Signed-off-by: Ganesh Vernekar <[email protected]> * Fix other places Signed-off-by: Ganesh Vernekar <[email protected]>
1 parent 585682c commit b44dc01

File tree

5 files changed

+2
-6
lines changed

5 files changed

+2
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
* [ENHANCEMENT] query-frontend now also logs the POST data of long queries. #2481
5555
* [ENHANCEMENT] Experimental WAL: Ingester WAL records now have type header and the custom WAL records have been replaced by Prometheus TSDB's WAL records. Old records will not be supported from 1.3 onwards. Note: once this is deployed, you cannot downgrade without data loss. #2436
5656
* [ENHANCEMENT] Redis Cache: Added `idle_timeout`, `wait_on_pool_exhaustion` and `max_conn_lifetime` options to redis cache configuration. #2550
57+
* [ENHANCEMENT] WAL: the experimental tag has been removed on the WAL in ingesters.
5758
* [BUGFIX] Ruler: Ensure temporary rule files with special characters are properly mapped and cleaned up. #2506
5859
* [BUGFIX] Fixes #2411, Ensure requests are properly routed to the prometheus api embedded in the query if `-server.path-prefix` is set. #2372
5960
* [BUGFIX] Experimental TSDB: fixed chunk data corruption when querying back series using the experimental blocks storage. #2400

docs/architecture.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ The **write-ahead log** (WAL) is used to write to a persistent local disk all in
180180

181181
Contrary to the sole replication and given the persistent local disk data is not lost, in the event of multiple ingesters failure each ingester will recover the in-memory series samples from WAL upon subsequent restart. The replication is still recommended in order to ensure no temporary failures on the read path in the event of a single ingester failure.
182182

183-
The WAL for the chunks storage is an experimental feature (disabled by default), while it's always enabled for the blocks storage.
183+
The WAL for the chunks storage is disabled by default, while it's always enabled for the blocks storage.
184184

185185
#### Ingesters write de-amplification
186186

docs/configuration/v1-guarantees.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ Cortex is an actively developed project and we want to encourage the introductio
3535
Currently experimental features are:
3636

3737
- TSDB block storage.
38-
- Ingester chunk WAL.
3938
- Cassandra storage engine.
4039
- Azure blob storage.
4140
- Zone awareness based replication.

docs/production/ingesters-with-wal.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ Currently the ingesters running in the chunks storage mode, store all their data
99

1010
To use WAL, there are some changes that needs to be made in the deployment.
1111

12-
_The WAL is currently considered experimental._
13-
1412
## Changes to deployment
1513

1614
1. Since ingesters need to have the same persistent volume across restarts/rollout, all the ingesters should be run on [statefulset](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/) with fixed volumes.

pkg/ingester/wal.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,6 @@ func newWAL(cfg WALConfig, userStatesFunc func() map[string]*userState, register
110110
return &noopWAL{}, nil
111111
}
112112

113-
util.WarnExperimentalUse("Chunks WAL")
114-
115113
var walRegistry prometheus.Registerer
116114
if registerer != nil {
117115
walRegistry = prometheus.WrapRegistererWith(prometheus.Labels{"kind": "wal"}, registerer)

0 commit comments

Comments
 (0)