Ensure that convert_project
works with compilation databases that use the command
field
#720
Labels
convert_project
works with compilation databases that use the command
field
#720
convert_project
currently has some logic that only works if the compilation database (compile_commands.json
file) uses thearguments
field rather than thecommand
field:checkedc-clang/clang/tools/3c/utils/port_tools/generate_ccommands.py
Lines 152 to 163 in 2a0df40
It seems that, knowing this, we've mostly standardized (notably, in the benchmark workflow) on using compilation databases that use
arguments
(as generated by Bear) rather thancommand
(as generated bycmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
), and we haven't made much of an effort to address thecommand
case in recent changes toconvert_project
. (To be clear, that "we" is mostly me.) I did a simple test withcmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
, and the 3C run seemed to work, but the macro expander didn't work at all.Ideally, all of our tools should support all important features of the Clang compilation database specification.
command
is the main feature we are missing;output
might also be worth considering where it is relevant (e.g., for the macro expander). We can start withconvert_project
. Some of ourutils-5c
tools may also need work, notablycompdb build
; we can file a separate issue in theutils-5c
repository if we want.The text was updated successfully, but these errors were encountered: