Skip to content

Clean up Constraints classes #699

Open
@kyleheadley

Description

@kyleheadley

Currently, there is one Constraint class and one Geq subclass, both in Constraints.h. Most of the code is written as if there is only one constraint type, with extra code to convert. The comment on the Constraint class even suggests it's a "a >= b" constraint even though that's not true.

If we don't plan on adding additional constraint types, we could combine these into one to reduce confusion and code.

If we need them separate for future expansion, we should define some expectations and refactor code to be tolerant of multiple values without skipping them.

Or if I just didn't understand, we should clarify here and add the final explanation as comments in the code.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions