[Issue]: Unable to upgrade, "The selected directory is not empty"

[Svish]

What happened?

I tried to follow the upgrade instructions from the README by running the new installer and selecting my current installation and symlink folder, but when selecting my current symlink folder I'm getting the following error:

The selected directory is not empty. Please choose a different path.

I'm currently on version 1.1.12, and tried to upgrade to the (currently) latest 1.2.2 using nvm-setup.exe

What did you expect to happen?

Expected the installation to work without hickups.

Version

1.1.12

Which version of Windows?

Windows 10

Which locale?

Western European

Which shell are you running NVM4W in?

Command Prompt

User Permissions?

I don't know (Default)

Is Developer Mode enabled?

Yes

Relevant log/console output

No response

Debug Output

<username> is not using admin or elevated rights.

Command Prompt - nvm  debug
Windows Version: 10.0 (Build 22631)

Windows Developer Mode: UNKNOWN (user cannot read registry)

NVM4W Version:      1.1.12
NVM4W Path:         C:\dev\tools\nvm\nvm.exe
NVM4W Settings:     C:\dev\tools\nvm\settings.txt
NVM_HOME:           C:\dev\tools\nvm
NVM_SYMLINK:        C:\dev\tools\nvm\nodejs
Node Installations: C:\dev\tools\nvm

Total Node.js Versions: 3
Active Node.js Version: v20.18.0

IPv6 is enabled. This can slow downloads significantly.

No problems detected.

Find help at https://github.com/coreybutler/nvm-windows/wiki/Common-Issues

Anything else?

No response

[coreybutler]

The installer is not detecting existing installs properly. I can fix this, but it might take a bit of work/time. In the meantime, you can delete the nodejs symlink at C:\dev\tools\nvm\nodejs, which should allow you to proceed with the installation.

That said, you may want to wait a few hours if you can. I'm going to release v1.2.3 with additional fixes for issues that surfaced in 1.2.2.

[xSkeletor]

Hi @coreybutler! Any word on a patch being dropped for this issue along with other ones?

[coreybutler]

Hopefully over the weekend.

[coreybutler]

It might be another week still. Unfortunately, a major home repair has been taking longer than expected.

[jtabox]

I stumbled upon the same issue while trying to use the installer to upgrade nvm, so instead I just downloaded the zip file that doesn't require installation and dropped its files in the directory I have nvm installed.

I assume if you have existing node installs that you wanna keep then you already have a previous version of nvm installed? It'll ask to overwrite most of the existing files, most importantly the scripts and executables, let it. And it'll also add some icons if you didn't already have them, but it won't touch the existing nodejs folders.

And since you have a previous version installed you don't need to set the environment variables, they're already set.

[xSkeletor]

Hey @coreybutler, are you still planning to release a fix for this issue?

[SayakMukhopadhyay]

Instead of deleting the symlinked folder, can I do nvm off, run the installer and nvm on again? Or would the installer turn on nvm anyway?

EDIT: It doesn't turn back on by itself and needs to be turned on. But it works! Also, note that when nvm is turned back on, it activates the oldest Node installed.