Skip to content

feat: Allow specifying a custom cuDNN version #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Eta0 wants to merge 1 commit into
base: eta/nccl-2.18.3-and-cuda-12.2
Choose a base branch
from
Draft

feat: Allow specifying a custom cuDNN version #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ on:
nccl-version:
required: true
type: string
cudnn-version:
required: false
type: string
cuda-samples-version:
required: true
type: string
Expand Down Expand Up @@ -75,6 +78,7 @@ jobs:
CUDA_VERSION_MINOR=${{ inputs.cuda-version-minor }}
CUDA_VERSION_MAJOR=${{ inputs.cuda-version-major }}
TARGET_NCCL_VERSION=${{ inputs.nccl-version }}
CUDNN_VERSION=${{ inputs.cudnn-version }}
CUDA_SAMPLES_VERSION=${{ inputs.cuda-samples-version }}
HPCX_VERSION=${{ inputs.hpcx-version }}
HPCX_NCCL_VERSION=${{ inputs.hpcx-nccl-version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ubuntu-20.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
cuda-version-minor: "12.2.0"
cuda-version-major: "12.2"
nccl-version: 2.18.3-1
cudnn-version: "8.9.3.*-1+cuda12.?"
cuda-samples-version: "12.2"
hpcx-version: "2.15"
hpcx-nccl-version: "2.17"
Expand Down
22 changes: 21 additions & 1 deletion Dockerfile.ubuntu20
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
ARG CUDA_VERSION_MINOR=11.7.1
ARG BASE_IMAGE=nvidia/cuda:${CUDA_VERSION_MINOR}-cudnn8-devel-ubuntu20.04
FROM ${BASE_IMAGE}

# Patch in cuDNN manually by specfiying a version here
# only if a base image with cuDNN is not available
ARG CUDNN_VERSION=""

# Effectively a ternary _CUDNN_IMAGE = CUDNN_VERSION ? "add-cudnn" : BASE_IMAGE
ARG _CUDNN_IMAGE=${CUDNN_VERSION:+add-cudnn}
ARG _CUDNN_IMAGE=${_CUDNN_IMAGE:-$BASE_IMAGE}

FROM ${BASE_IMAGE} as add-cudnn
ARG CUDNN_VERSION

RUN apt-get -qq update && \
apt-get -qq install -y --allow-change-held-packages --no-install-recommends \
"libcudnn8=${CUDNN_VERSION}" \
"libcudnn8-dev=${CUDNN_VERSION}" && \
apt-mark hold libcudnn8 && \
apt-get clean && \
rm -rf /var/lib/apt/lists/*

FROM ${_CUDNN_IMAGE}

ARG CUDA_VERSION_MAJOR=11.7
ARG TARGET_NCCL_VERSION=2.14.3-1
Expand Down