-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the UI #110
Comments
Pinging @AKindWorld, Please send some of your mockups here :) ( do note that we need a mobile mockup too ) |
If we go this route I will use React this time. Next.JS seems a good pick for this kind of project and we have Tailwind to power it all up. |
Or should i go with just django? I donno, Django's asset building pipeline is finicky. |
Hi there! I was just working on this, however I'll need a bit more time to brainstorm a responsive UI. So far, I've redesigned it based on the Anime Info page, but I'll still need to add lots of components. I've decided on some parts of the design system, but I'll need to think through the UX as well. I'll quickly make a list of all possible design screens needed.
[all screens will have a, b, c (+more?) versions for various screen sizes. If I get enough time, I might be able to create a responsive mockup, but I can't guarantee on that currently] Firstly I'll work on the design system (includes, but is not limited to, fonts, colors, icons and layouts), and then start off work on the various pages [order of importance ---> 3 --> 1 --> 4 --> rest]. Here is a link to the Figma file I'm working on: https://www.figma.com/file/knyOkHUChnJpsAsmuILhOk/Core-Project?node-id=0%3A1 If you're not familiar with Figma, don't worry! I just linked it so that you can see the stuff I'm working on. Ctrl + scroll to zoom in, normal scroll for vertical scroll, Shift + scroll for horizontal scroll is pretty much the most important shortcuts for viewing. The link currently doesn't have edit access (which is risky to share here). Also, I'd suggest starting a new project to better keep track of the components & redesigns. Otherwise, it's going to become pretty hard to discuss mockups (& their pros & cons) here. I think you can use whichever library you feel is best; I honestly don't have much experience using any of those, so I can't recommend any. I might be able to learn should I need to, since I've been wanting to learn those for quite a while. Thanks for reading my Design 101 essay lol also, I'll be replying to the other thread as soon as I finish working on the logo. |
Lemme branch this off and start a V3 project 🤞. The backend stays intact. Its the frontend that needs some work. 👀 On another note do you think we can use MUI? https://mui.com/ |
aha yup! I took a look at the docs, and it seems to be pretty good. Pre-styled components would save us a lot of time, and after that, we can just tweak the CSS as we need it to be. Good find! |
Working on it.🤞 For now lemme finish the backend work, The V2 (svelte) app seems mostly finished :) But svelte is not as mature as i thought it to be :\ Oh well back to react we are,
We will use a library called videojs take a look at that.
yep. But what kind of pages should we add ? A wiki page?
Well take my advice and dont learn anything related to JS. Its a mess. I donno how i keep my sanity while working with something that breaks constantly. ( But if you wanna shoot yourself in the foot start with javascript and react )
I am familiar with Figma. But as someone who got a constant F in Arts i feel myself disqualified to talk about designs.
Okay no problem. MUI is mostly responsive :P >___< But as someone who will learn it for this project i cant comment much.
Gimme some time. I never used the project board. I will look into it after i fix the anime genre and the anime studio links :) Ultimately the backend is very robust. As someone who contributed to the django project i know very well how it works. The frontend part is not that tough. I will mull it through :).
You seem very talented. You have a bright future ahead of you. I wish you a happy future :D So another question. Would you like to have write access to this repo? That way you yourself can make quick design fixes. |
Hi! I have just come across this repo and as a anime lover, I would love to contribute to this project (if you plan on writing this in React and Next.js) :] |
I do am planning to use next.js :) ( Backend stays python tho . Because i still didn't find a good reason to switch away from it. If you do see any comment on #31 ) I have some questions :
In any case welcome to project |
@AKindWorld would you take a look at Also would you add a section in the profile page where it shows all the animes that a user watched ? Have a good day 🤞 |
Sure thing! Take your time. Above all else, we want a very strong backend, so that's the most important part, and you've got that covered.
Sounds great! VideoJS looks amazing, and I'm all in for customizability.
I think so. Mostly, for now, a FAQ, Contact Page, Terms/Policies, & Support page are the bare minimum pages needed. Other than that, let's see. ah- also a Request page maybe? I think you had a field for that in the Readme version.
Hahaha, alrighty. For now, I don't think I'll start learning anything.
Don' worry about it! Arts, as we know it, is hugely different from the UI & UX counterparts, and above everything, I think, it relies on experience than any sort of theoretical knowledge. I'm myself a hobby designer too. So anyways, feel free to chip in your thoughts!
Sure thing! Take your time. I think discussing mockups would be pretty hard even in the Projects, but atleast we'll be able to keep track of everything in there. Also, I need a bit of user feedback for most of my designs, otherwise I might make severe UX mistakes.
Thank you! And I'd say the same for you. I myself, can't make head or tail of backend systems, so design & possibly, little bits of frontend code are the only ways I can contribute.
I would really appreciate it, but currently, (until the design system is final), I won't make any changes to the project. After I've decided on everything though, I might be able to help here and there.
I like both of those. I personally am favoring TailwindCSS more right now, but in the end, as long as it works good, it's all fine. We would have to manually tweak components either way. Also, I'm not much of an expert in this topic, but whichever has the least size and network load, if any, should be the one we work with.
Sure! I'll get to that when I start the Profile page designing. Also, about all your feedbacks related to the UI, I'll try my best to work on them. Right now, I'm designing the Base design system, once that's done, I'll get started with the Home Page and eventually, the rest of the pages. Thanks for your advices and for reading this! :) Have a great time ahead! ^^ |
@AKindWorld I added you as a collaborator. I might go AWOL because i have exams soon. So in that time i recon you can do a little bit of poking in this Repo :) Now i have the anime genre part going on i still need to add more things to the API :) Since we are going to work on the frontend soon, its better to tidy up the backend a bit more :) Thanks for reading 🥳 |
Thank you. I have accepted it as well. Also, I've finished the Base design system & todo list, and the Homepage UI is currently underway. You can take a look at the Figma file (same link). Feel free to let me know if there's anything I should change, or if the design looks okay. Also, should I start keeping track of stuff in the Projects board, or would you do that later on? (There's no hurry though) Also, wish you best of luck for your exams! |
Thanks mate :) I hate studies but in this world people seem to care more about a degree than talent thus forcing me to waste my time on subjects that doesn't interest me. (Fun fact, I failed in Computer Studies XD)
Add anything you like :) Treat this repo as part of our own. I think we should open a new github organization based on Coreproject https://github.com/CoreProject and move this repo there :) Thoughts ?
Lets take a look at what our api can return :
|
I have a question regarding the API design.
Thanks for reading 🥳 |
Thank you, I'll do that soon then. Also, that's a great idea. Although since I don't know any of the downsides of that, it's okay even if we can't. If we can, then that's great! About the anime info page, currently it's unfinished, and I'm also planning an overhaul based off the new system. However, the data fields would stay the same, pretty much.
Sure sure. I actually have something in mind regarding that, but it's not possible to express it in a mockup now. I'll try and see what I can do about it.
I think you can also take a look at the anilist.co API, I personally really like AniList, and the API is also free for us. Otherwise, there's the Kitsu/Hummingbird API. I think this Taiga doc has all the comparisons. If nothing works, then we can always create one from scratch ^^ Good day to you! |
So my plan is to update the anime entries from this project. Lets see an example :
So essentially when you start watching a episode in this site, the site will make an internal request on your behalf to update the entries.
Yea I think we need to discuss this stuff. So currently the site works like this.
But my end goal is to use one site to update
I never used this site. Lemme take a look :). Took a look. They are using
Okay then :) But i was asking to add a trailer / video ( for animes that have it ) option. I also have a small favor to ask you :). Make a hard fork of this project in your repo and keep it private :) . In the event of a DMCA takedown, we will have another copy of this project Thanks for reading. Have a good day :) |
Aha yeah, I understand. Basically a built-in episode tracker.
I see, I see. I don't understand much of the internal workings, but basically we're mapping the anime ids directly from MAL. Also, from what I know of, this will make integrating with MAL-sync much easier too, probably.
Oh sorry, seems I didn't read that part. Sure, I'll design it while keeping that in mind.
Sure thing! I'll do that right now, and also, (try to) keep regular offline backups, just in case. EDIT: Seems like I cannot change visibility of a fork; do you know any workarounds? About the Home Page part, here's how it should work: https://www.figma.com/proto/knyOkHUChnJpsAsmuILhOk/Core-Project?page-id=0%3A1&node-id=80%3A7&viewport=241%2C48%2C0.32&scaling=scale-down&starting-point-node-id=76%3A5. That's just the top part for 1280x720 or greater screens. The 4th mockup is the whole look of the Home Page in vertical format (so far unfinished). I'll make modifications for other screen sizes, etc later on. Mobile soon too ^^ I'll update the Figma file with the font info too. Thanks for reading! |
What i meant by hard fork is :
The site is looking good. But do you know which javascript slider do they use? It seems like i can try to recreate it using Swiper but i cant make it exactly like that without some tweaking.
I DMed this repo ( in .7z ) to some of my friends in discord. Rest assured that this repo wont go down completely :D But i am sorry to say that i cannot work like i used to for this project. Like i will push updates but feature releases will be slow for a couple of months ( exams sigh ) But dont think i will be leaving this project, i will contribute when i have some gaps in studies. ( in the mean time can you watch over this project? You have write permissions :D ) Thanks for reading. Have a good day :D |
For now my main goal is to add Next.JS and do some bootstrapping. Expect it to arrive in 1-2 days :) But if i dont get much response on react side, i am gonna go with either vue or svelte. By using svelte, i can scrape much of the codes of V2. Thoughts @AKindWorld? |
Yup alrighty! I've finished making a hard-fork of the repo. I actually chose sadasfas as the name cuz it was interestingly funny xD. If you want to, I can add you a collaborator too.
Sure thing! Don't worry, I'll keep watch. Good luck for your exams; if it comforts you any bit, I hate exams and the traditional modes of education too. It's very much useless and exists only to weed out people rather than give everyone a unique purpose for living. True talents aren't recognized, and instead people are motivated to become machines that memorize for a short time. But, well... sigh
Yup, I think that's okay. Also, I'm not much knowledgeable in these stuff, but do you think we can create an app-like feel? I think svelte does that natively, but as I said, I'm not too sure about it. A good example of the type I'm talking about is Sorry for the delay in replying! Wish you a great time ahead! |
The successor is
Yay!! Congratulations. This will make the repo a bit more safe :)
I picked
Umm that will make finding the repo easy. So for now i would have to turn down the offer 😢 . ( Maybe someday i will have a second github account and we can see then 😃 )
Sapper is a framework based on Svelte. Like how
I plan on making an app someday. Most of my friends said an app makes life a lot easier. So in that sense we have 2 considerations.
Even with these problems i would like to go for a App like feel :) With PWA.
In my country people think i cant code a website.... xD
Truer words were never spoken
Thanks!!! It does comfort me. Knowing that someone else thinks the same. Thanks for reading. |
Sorry for the late reply!
Yes we can, TypeScript will be better in the long run
Yes
Yes, Styled-Components
Haven't used this api yet but I'm pretty sure I can consume it :) I shall look at the docs soon.
Not familiar with django unfortunately, but I could learn on the way.
Yes
Yes. Tailwind, Bootstrap, SemanticUI, Materialize... you name it!
The upgrade path for NextJS is fairly simple and easy to use. I don't think migrating from CRA to NextJS will be difficult especially for this project. I don't know how big of a project SoundCore is but migrating with messy code is a pain! what I would do is start a new project along with NextJS, installing the right dependencies and updating the code as you migrate to make it look clean and organised. This way you will run into less bugs and have more control. Check this out
I have not used react-query as of yet but I have read the docs and familiar with the code. It is very similar to Apollo which is used for GraphQL APIS. Since we are using jikan.moe, react-query should be great.
I can work with animejs
I don't think we need GraphQL.
Probably SSG but what's great about NextJS is that we could choose which pre-rendering form we'd like to use for each page. We can create a "hybrid" Next.js app by using Static Generation for most pages and using Server-side Rendering for others. I shall wait for the designs to be finalised. Feel free to ask for my opinion on UI designs. |
Hi, @Steven-Ha-88
How about bulma? xD joking ( we dont need bulma ). You are probably more experienced in Frontend than me. ( which is really awesome )
So our backend API is sourced from
Although i used Django for this project. I would love to rewrite it in some new framework. ( Check this for some more context ) I hate the way how django handles stuff. ( maybe you can suggest a framework? )
I dont know how this and this works anymore
I agree with this. But i have questions. Do we need some testing ?
While it would be a good thing but i am curious of how much requests per second can it handle ?
Take a look at #115 ( do you think we can use Tailwind for this? ) and #114 ( though #114 is not UI design related its still a good place to discuss Libraries ) :) Also before you start working are you comfortable with the Thanks for reading :) Have a good day.. |
I will be doing the ui part :) I am closing this issue now :) |
Hey @Steven-Ha-88, I have decided that i will use svelte again for this project. I tried to use next.js ( the home page was written using next.js till this part ) My problems with next.js :
Overall I rewrote the project in both next.js and svelte. See the difference for yourself. |
As the title goes.
Currently The site looks like this
Login Page
Register page
Edit Info Page
Home Page
Anime Info Page ( with episodes ) :
Anime Info Page ( without episodes ) :
If you think you see the need for any improvement comment down below 📃
The text was updated successfully, but these errors were encountered: