Skip to content

Multiple instances of "Any" in the Workflow Admin forms that Appear to function differently #821

@streatim

Description

@streatim

Creating a separate ticket to slice this issue off the work I'm currently doing and document it. At present the Admin display for the Resources Module Workflow forms check to see if an ID is set for Resource Format, Acquisition Type, and Resource Type ID - if there isn't one set (or it's blank), it hardcodes a default description of "any" for the row in the display. The form itself displays a blank option.

The issue is that in the forms themselves, the vanilla installation of CORAL comes with "Any" as a selectable value with an ID of 3, 4, and 1 respectively; this value can be edited in the Administrative forms. Without looking at the actual workflow code, my suspicion is that the Admin Display is describing how the actual workflow code works (so that if there isn't a Resource Type ID selected for the workflow, it applies to all resources regardless of Resource Type ID), but the current, default setup creates a situation where a workflow could have an "any" Resource Type (blank ID) or an "Any" Resource Type (which would only apply to those resources that have "Any" selected).

I would suggest that we change this so that the default, blank value for the form is "Any" or "All" and to remove the values that are loaded in with a fresh install, but it would require a deeper look at the Workflow code to confirm understanding.

Metadata

Metadata

Assignees

No one assigned

    Labels

    resourcesIssues Identified in the Resources Module

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions