address feedback from recurse

Author: sestinj

binary/utils/bundle-binary.js

@@ -91,8 +91,9 @@ async function bundleBinary(target) {
     child.on("message", (msg) => {
       if (msg.error) {
         reject();
+      } else {
+        resolve();
       }
-      resolve();
     });
   });
 }

extensions/vscode/scripts/download-copy-sqlite-esbuild.js

@@ -154,8 +154,9 @@ async function copySqlite(target) {
     child.on("message", (msg) => {
       if (msg.error) {
         reject();
+      } else {
+        resolve();
       }
-      resolve();
     });
   });
 }
@@ -176,8 +177,9 @@ async function copyEsbuild(target) {
     child.on("message", (msg) => {
       if (msg.error) {
         reject();
+      } else {
+        resolve();
       }
-      resolve();
     });
   });
 }

extensions/vscode/scripts/esbuild.js

@@ -1,4 +1,5 @@
 const fs = require("fs");
+
 const { writeBuildTimestamp } = require("./utils");
 
 const esbuild = require("esbuild");
@@ -49,7 +50,7 @@ const esbuildConfig = {
   ],
 };
 
-(async () => {
+void (async () => {
   // Create .buildTimestamp.js before starting the first build
   writeBuildTimestamp();
   // Bundles the extension into one file

extensions/vscode/scripts/install-copy-nodemodule.js

@@ -101,8 +101,9 @@ async function installAndCopyNodeModules(packageName, toCopy) {
     child.on("message", (msg) => {
       if (msg.error) {
         reject();
+      } else {
+        resolve();
       }
-      resolve();
     });
   });
 }