Skip to content

Commit 91a1940

Browse files
Merge pull request #54 from contentstack/hotfix/img_tag
fix: wrapped img tag with a tag
2 parents 4219fd6 + 743a195 commit 91a1940

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

.github/workflows/maven-publish.yml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,32 @@ jobs:
1313
- name: Set up Maven Central Repository
1414
uses: actions/setup-java@v3
1515
with:
16-
java-version: '8'
16+
java-version: '11'
1717
distribution: 'adopt'
1818
server-id: ossrh
19-
server-username: ${{ secrets.OSSRH_USERNAME }}
20-
server-password: ${{ secrets.OSSRH_TOKEN }}
21-
gpg-passphrase: ${{ secrets.GPG_PASSPHRASE }}
19+
server-username: MAVEN_USERNAME
20+
server-password: MAVEN_PASSWORD
21+
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
22+
gpg-passphrase: GPG_PASSPHRASE
2223
- name: Publish package
23-
run: mvn --batch-mode deploy
24+
run: mvn --batch-mode -Dgpg.passphrase=${{ secrets.GPG_PASSPHRASE }} deploy
25+
env:
26+
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
27+
MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
28+
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
2429
publish-github:
2530
runs-on: ubuntu-latest
2631
steps:
2732
- uses: actions/checkout@v3
2833
- name: Set up Java for publishing to GitHub Packages
2934
uses: actions/setup-java@v3
3035
with:
31-
java-version: '8'
36+
java-version: '11'
3237
distribution: 'adopt'
3338
server-id: github
39+
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
40+
gpg-passphrase: ${{ secrets.GPG_PASSPHRASE }}
3441
- name: Publish to GitHub Packages
35-
run: mvn --batch-mode deploy
42+
run: mvn --batch-mode -Dgpg.passphrase=${{ secrets.GPG_PASSPHRASE }} deploy
3643
env:
3744
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,12 @@
210210
<goals>
211211
<goal>sign</goal>
212212
</goals>
213+
<configuration>
214+
<gpgArguments>
215+
<arg>--pinentry-mode</arg>
216+
<arg>loopback</arg>
217+
</gpgArguments>
218+
</configuration>
213219
</execution>
214220
</executions>
215221
</plugin>

src/main/java/com/contentstack/utils/render/DefaultOption.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@ public String renderNode(String nodeType, JSONObject nodeObject, NodeCallback ca
109109
case "img":
110110
String assetLink = getNodeStr(nodeObject, "asset-link");
111111
if (!assetLink.isEmpty()) {
112+
JSONObject attrs = nodeObject.optJSONObject("attrs");
113+
if (attrs.has("link")) {
114+
return "<a href=\"" + escapeInjectHtml(nodeObject, "link") + "\" />" + "<img" + strAttrs + " src=\"" + escapeInjectHtml(nodeObject, "asset-link") + "\" />" + children + "</a>";
115+
}
112116
return "<img" + strAttrs + " src=\"" + escapeInjectHtml(nodeObject, "asset-link") + "\" />" + children;
113117
}
114118
return "<img" + strAttrs + " src=\"" + escapeInjectHtml(nodeObject, "src") + "\" />" + children;

0 commit comments

Comments
 (0)