Skip to content

Commit 3a09fea

Browse files
committed
fix: 🐛 Release items
Release items create and delete funtionality issue resolved
1 parent 8a7ee3b commit 3a09fea

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

lib/contentstack.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ import httpClient from './core/contentstackHTTPClient.js'
3939
* import * as contentstack from '@contentstack/management'
4040
* const client = contentstack.client({ timeout: 50000 })
4141
*
42+
* @prop {number=} params.maxRequests - Optional maximum number of requests SDK should send concurrently. Default is 10 request.
43+
* @example //Set the `maxRequests` to 50000ms
44+
* import * as contentstack from '@contentstack/management'
45+
* const client = contentstack.client({ maxRequests: 5 })
46+
*
4247
* @prop {boolean=} params.retryOnError - Optional boolean for retry on failuer. Default is true
4348
* @example //Set the `retryOnError` to false
4449
* import * as contentstack from '@contentstack/management'

lib/stack/release/items/index.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,25 @@ export function ReleaseItem (http, data = {}) {
5252
* client.stack({ api_key: 'api_key'}).release('release_uid').delete({items})
5353
* .then((response) => console.log(response.notice))
5454
*/
55-
this.delete = async (param) => {
56-
if (param === undefined) {
55+
this.delete = async (items) => {
56+
let param = {}
57+
if (items === undefined) {
5758
param = {all: true}
5859
}
5960
try {
6061
const headers = {
6162
headers: { ...cloneDeep(this.stackHeaders) },
63+
data: {
64+
...cloneDeep(items)
65+
},
6266
params: {
6367
...cloneDeep(param)
6468
}
6569
} || {}
6670

6771
const response = await http.delete(this.urlPath, headers)
6872
if (response.data) {
69-
return response.data
73+
return new Release(http, { ...response.data, stackHeaders: data.stackHeaders })
7074
} else {
7175
throw error(response)
7276
}
@@ -123,17 +127,14 @@ export function ReleaseItem (http, data = {}) {
123127
const headers = {
124128
headers: {
125129
...cloneDeep(this.stackHeaders)
126-
},
127-
params: {
128-
...cloneDeep(param)
129130
}
130131
} || {}
131132

132133
try {
133-
const response = await http.post(param.item ? `releases/${data.releaseUid}/item` : this.urlPath, data, headers)
134+
const response = await http.post(param.item ? `releases/${data.releaseUid}/item` : this.urlPath, param, headers)
134135
if (response.data) {
135136
if (response.data) {
136-
return new Release(http, response.data)
137+
return new Release(http, { ...response.data, stackHeaders: data.stackHeaders })
137138
}
138139
} else {
139140
throw error(response)

package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/management",
3-
"version": "1.2.0",
3+
"version": "1.2.0-beta",
44
"description": "The Content Management API is used to manage the content of your Contentstack account",
55
"main": "dist/node/contentstack-management.js",
66
"browser": "dist/web/contentstack-management.js",
@@ -14,7 +14,6 @@
1414
"nyc": {
1515
"exclude": [
1616
"**/bulkOperation",
17-
"**/items",
1817
"**/test"
1918
]
2019
},
@@ -34,8 +33,7 @@
3433
"test:debug": "BABEL_ENV=test mocha debug --require @babel/register ./test",
3534
"lint": "eslint lib test",
3635
"format": "eslint --fix lib test",
37-
"prepack": "npm run build && npm run generate:docs",
38-
"prepublish" : "npm run build && npm run generate:docs",
36+
"prepare" : "npm run build && npm run generate:docs",
3937
"pretest": "rimraf coverage && npm run lint",
4038
"precommit": "npm run lint",
4139
"prepush": "npm run test:unit",

0 commit comments

Comments
 (0)