fix(wsl): model mounting (#2385)

* fix(wsl): model mounting

Signed-off-by: axel7083 <[email protected]>

* fix: remove unnecessary trailing slash

Signed-off-by: axel7083 <[email protected]>

* fix: remove unnecessary trailing slash

Signed-off-by: axel7083 <[email protected]>

* fix: remove unnecessary trailing slash

Signed-off-by: axel7083 <[email protected]>

---------

Signed-off-by: axel7083 <[email protected]>

Author: axel7083

packages/backend/src/utils/modelsUtils.spec.ts

@@ -20,12 +20,14 @@ import { process as apiProcess } from '@podman-desktop/api';
 import {
   deleteRemoteModel,
   getLocalModelFile,
+  getMountPath,
   getRemoteModelFile,
   isModelUploaded,
   MACHINE_BASE_FOLDER,
 } from './modelsUtils';
 import type { ModelInfo } from '@shared/src/models/IModelInfo';
 import { getPodmanCli } from './podman';
+import { join, posix } from 'node:path';
 
 vi.mock('@podman-desktop/api', () => {
   return {
@@ -72,6 +74,48 @@ describe('getLocalModelFile', () => {
   });
 });
 
+describe('getMountPath', () => {
+  const DUMMY_MODEL: ModelInfo = {
+    id: 'dummyModelId',
+    file: undefined,
+    properties: {},
+    description: '',
+    name: 'dummy-model',
+  };
+
+  const DOWNLOADED_MODEL: ModelInfo & { file: { path: string; file: string } } = {
+    ...DUMMY_MODEL,
+    file: {
+      path: 'dummyPath',
+      file: 'dummy.guff',
+    },
+  };
+
+  const UPLOADED_MODEL: ModelInfo & { file: { path: string; file: string } } = {
+    ...DUMMY_MODEL,
+    file: {
+      path: MACHINE_BASE_FOLDER,
+      file: 'dummy.guff',
+    },
+  };
+
+  test('file in ModelInfo undefined', () => {
+    expect(() => {
+      getMountPath(DUMMY_MODEL);
+    }).toThrowError('model is not available locally.');
+  });
+
+  test('should join path with respect to system host', () => {
+    const path = getMountPath(DOWNLOADED_MODEL);
+    expect(path).toBe(join(DOWNLOADED_MODEL.file.path, DOWNLOADED_MODEL.file.file));
+  });
+
+  test('uploaded model should use posix for join path', () => {
+    const path = getMountPath(UPLOADED_MODEL);
+    expect(path).toBe(posix.join(MACHINE_BASE_FOLDER, UPLOADED_MODEL.file.file));
+  });
+});
+
 describe('getRemoteModelFile', () => {
   test('file in ModelInfo undefined', () => {
     expect(() => {
@@ -91,7 +135,7 @@ describe('getRemoteModelFile', () => {
       },
     } as unknown as ModelInfo);
 
-    expect(path).toBe(`${MACHINE_BASE_FOLDER}dummy.guff`);
+    expect(path).toBe(posix.join(MACHINE_BASE_FOLDER, 'dummy.guff'));
   });
 });
 

packages/backend/src/utils/modelsUtils.ts

@@ -20,7 +20,7 @@ import { join, posix } from 'node:path';
 import { getPodmanCli } from './podman';
 import { process } from '@podman-desktop/api';
 
-export const MACHINE_BASE_FOLDER = '/home/user/ai-lab/models/';
+export const MACHINE_BASE_FOLDER = '/home/user/ai-lab/models';
 
 /**
  * Given a model info object return the path where is it located locally
@@ -31,6 +31,19 @@ export function getLocalModelFile(modelInfo: ModelInfo): string {
   return join(modelInfo.file.path, modelInfo.file.file);
 }
 
+/**
+ * Return the path to mount where the model is located
+ * @param modelInfo
+ */
+export function getMountPath(modelInfo: ModelInfo): string {
+  if (modelInfo.file === undefined) throw new Error('model is not available locally.');
+  // if the model is uploaded we need to use posix join
+  if (modelInfo.file.path === MACHINE_BASE_FOLDER) {
+    return posix.join(MACHINE_BASE_FOLDER, modelInfo.file.file);
+  }
+  return join(modelInfo.file.path, modelInfo.file.file);
+}
+
 /**
  * Given a model info object return the theoretical path where the model
  * should be in the podman machine

packages/backend/src/workers/provider/LlamaCppPython.ts

@@ -24,7 +24,7 @@ import type {
 } from '@podman-desktop/api';
 import type { InferenceServerConfig } from '@shared/src/models/InferenceServerConfig';
 import { InferenceProvider } from './InferenceProvider';
-import { getLocalModelFile, getModelPropertiesForEnvironment } from '../../utils/modelsUtils';
+import { getModelPropertiesForEnvironment, getMountPath } from '../../utils/modelsUtils';
 import { DISABLE_SELINUX_LABEL_SECURITY_OPTION } from '../../utils/utils';
 import { LABEL_INFERENCE_SERVER } from '../../utils/inferenceUtils';
 import type { TaskRegistry } from '../../registries/TaskRegistry';
@@ -83,7 +83,7 @@ export class LlamaCppPython extends InferenceProvider {
     };
 
     // get model mount settings
-    const filename = getLocalModelFile(modelInfo);
+    const filename = getMountPath(modelInfo);
     const target = `/models/${modelInfo.file.file}`;
 
     // mount the file directory to avoid adding other files to the containers

packages/backend/src/workers/provider/WhisperCpp.ts

@@ -25,7 +25,7 @@ import type { ContainerProviderConnection, MountConfig } from '@podman-desktop/a
 import { DISABLE_SELINUX_LABEL_SECURITY_OPTION } from '../../utils/utils';
 import { whispercpp } from '../../assets/inference-images.json';
 import type { PodmanConnection } from '../../managers/podmanConnection';
-import { getLocalModelFile } from '../../utils/modelsUtils';
+import { getMountPath } from '../../utils/modelsUtils';
 
 export class WhisperCpp extends InferenceProvider {
   constructor(
@@ -69,7 +69,7 @@ export class WhisperCpp extends InferenceProvider {
     if (!connection) throw new Error('no running connection could be found');
 
     // get model mount settings
-    const filename = getLocalModelFile(modelInfo);
+    const filename = getMountPath(modelInfo);
     const target = `/models/${modelInfo.file.file}`;
 
     // mount the file directory to avoid adding other files to the containers

packages/backend/src/workers/uploader/WSLUploader.spec.ts

@@ -119,7 +119,7 @@ describe('upload', () => {
       'machine2',
       'mkdir',
       '-p',
-      '/home/user/ai-lab/models/',
+      '/home/user/ai-lab/models',
     ]);
     expect(process.exec).toBeCalledWith('podman.exe', [
       'machine',