Skip to content

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Aug 13, 2025

We are now moving to the monorepo at
https://github.com/containers/container-libs .

Summary by Sourcery

Chores:

  • Update .packit.yaml to ignore all Packit job triggers

We are now moving to the monorepo at
https://github.com/containers/container-libs .

Signed-off-by: Lokesh Mandvekar <[email protected]>
@sourcery-ai
Copy link

sourcery-ai bot commented Aug 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR uniformly disables all Packit CI jobs by updating each job’s trigger configuration in the .packit.yaml manifest to “ignore”.

File-Level Changes

Change Details Files
Disable all Copr build jobs by setting their triggers to ignore
  • Changed copr_build trigger from pull_request to ignore for containers-common-fedora
  • Changed copr_build trigger from pull_request to ignore for containers-common-eln
  • Changed copr_build trigger from pull_request to ignore for containers-common-centos
  • Changed copr_build trigger from commit to ignore for production fedora builds
.packit.yaml
Disable downstream proposal jobs by setting triggers to ignore
  • Changed propose_downstream trigger from release to ignore for Fedora targets
  • Changed propose_downstream trigger from release to ignore for CentOS targets
.packit.yaml
Disable Koji build job by setting its trigger to ignore
  • Changed koji_build trigger from commit to ignore for Fedora koji builds
.packit.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lsm5 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lsm5, sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please assign luap99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member

Luap99 commented Aug 13, 2025

Should we wait for the monorepo move to complete first? It could still be we have to do releases here for a potential 5.6.1 if we find any important bug. Although I guess it would not matter for common much as it only ships config files not code

@lsm5
Copy link
Member Author

lsm5 commented Aug 13, 2025

Should we wait for the monorepo move to complete first? It could still be we have to do releases here for a potential 5.6.1 if we find any important bug. Although I guess it would not matter for common much as it only ships config files not code

Yes, if we expect config files to change in the individual repos then we should hold this. Otherwise shouldn't matter. I guess both this and containers/container-libs#4 should be handled at the same time.

@jankaluza
Copy link
Member

Hi, and thank you for your contribution!

We’ve recently migrated this repository into a new monorepo: containers/container-libs along with other repositories

As part of this migration, this repository is no longer accepting new Pull-Requests and therefore this Pull-Request is being closed.

Thank you very much for your contribution. We would appreciate your continued help in migrating this PR to the new container-libs repository. Please let us know if you are facing any issues.

You can read more about the migration and the reasoning behind it in our blog post: Upcoming migration of three containers repositories to monorepo.

Thanks again for your work and for supporting the containers ecosystem!

@jankaluza jankaluza closed this Aug 26, 2025
@lsm5 lsm5 deleted the disable-packit-jobs branch August 26, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants