Skip to content

Commit c0f6d57

Browse files
committed
Disable checkpoint/restore unit tests for docker
Currently, nerdctl CI uses docker 28.0.4, while docker version 28.x has a known regression that breaks Checkpoint/Restore functionality. The issue is tracked in the moby/moby project as moby/moby#50750. Signed-off-by: ChengyuZhu6 <[email protected]>
1 parent a59921c commit c0f6d57

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

cmd/nerdctl/checkpoint/checkpoint_create_linux_test.go

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,13 @@ import (
3030

3131
func TestCheckpointCreateErrors(t *testing.T) {
3232
testCase := nerdtest.Setup()
33-
testCase.Require = require.Not(nerdtest.Rootless)
33+
34+
testCase.Require = require.All(
35+
require.Not(nerdtest.Rootless),
36+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
37+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
38+
require.Not(nerdtest.Docker),
39+
)
3440
testCase.SubTests = []*test.Case{
3541
{
3642
Description: "too-few-arguments",
@@ -71,7 +77,12 @@ func TestCheckpointCreate(t *testing.T) {
7177
checkpointDir = "/dir/foo"
7278
)
7379
testCase := nerdtest.Setup()
74-
testCase.Require = require.Not(nerdtest.Rootless)
80+
testCase.Require = require.All(
81+
require.Not(nerdtest.Rootless),
82+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
83+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
84+
require.Not(nerdtest.Docker),
85+
)
7586
testCase.SubTests = []*test.Case{
7687
{
7788
Description: "leave-running=true",

cmd/nerdctl/container/container_start_linux_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,12 @@ func TestStartDetachKeys(t *testing.T) {
8484
func TestStartWithCheckpoint(t *testing.T) {
8585

8686
testCase := nerdtest.Setup()
87-
testCase.Require = require.Not(nerdtest.Rootless)
88-
87+
testCase.Require = require.All(
88+
require.Not(nerdtest.Rootless),
89+
// Docker version 28.x has a known regression that breaks Checkpoint/Restore functionality.
90+
// The issue is tracked in the moby/moby project as https://github.com/moby/moby/issues/50750.
91+
require.Not(nerdtest.Docker),
92+
)
8993
testCase.Setup = func(data test.Data, helpers test.Helpers) {
9094
// Use an in-memory tmpfs to model in-memory state without introducing extra processes
9195
// Single PID 1 shell: continuously increment a counter and write to /state/counter (tmpfs)

0 commit comments

Comments
 (0)