Merge pull request #4401 from Mr-Sunglasses/fix/#4313

feat: Add completions for 'nerdctl network create -o'

Author: AkihiroSuda

cmd/nerdctl/completion/completion_unix.go

@@ -38,6 +38,49 @@ func IPAMDrivers(cmd *cobra.Command, args []string, toComplete string) ([]string
 	return []string{"default", "host-local", "dhcp"}, cobra.ShellCompDirectiveNoFileComp
 }
 
+func NetworkOptions(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+	driver, _ := cmd.Flags().GetString("driver")
+	if driver == "" {
+		driver = "bridge"
+	}
+
+	var candidates []string
+	switch driver {
+	case "bridge":
+		candidates = []string{
+			"mtu=",
+			"com.docker.network.driver.mtu=",
+			"ip-masq=",
+			"com.docker.network.bridge.enable_ip_masquerade=",
+		}
+	case "macvlan":
+		candidates = []string{
+			"mtu=",
+			"com.docker.network.driver.mtu=",
+			"mode=bridge",
+			"macvlan_mode=bridge",
+			"parent=",
+		}
+	case "ipvlan":
+		candidates = []string{
+			"mtu=",
+			"com.docker.network.driver.mtu=",
+			"mode=l2",
+			"mode=l3",
+			"ipvlan_mode=l2",
+			"ipvlan_mode=l3",
+			"parent=",
+		}
+	default:
+		candidates = []string{
+			"mtu=",
+			"com.docker.network.driver.mtu=",
+			"parent=",
+		}
+	}
+	return candidates, cobra.ShellCompDirectiveNoSpace
+}
+
 func NamespaceNames(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 	globalOptions, err := helpers.ProcessRootCmdFlags(cmd)
 	if err != nil {

cmd/nerdctl/completion/completion_windows.go

@@ -38,3 +38,25 @@ func NetworkDrivers(cmd *cobra.Command, args []string, toComplete string) ([]str
 func IPAMDrivers(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 	return []string{"default"}, cobra.ShellCompDirectiveNoFileComp
 }
+
+func NetworkOptions(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+	driver, _ := cmd.Flags().GetString("driver")
+	if driver == "" {
+		driver = "nat"
+	}
+
+	var candidates []string
+	switch driver {
+	case "nat":
+		candidates = []string{
+			"mtu=",
+			"com.docker.network.driver.mtu=",
+		}
+	default:
+		candidates = []string{
+			"mtu=",
+			"com.docker.network.driver.mtu=",
+		}
+	}
+	return candidates, cobra.ShellCompDirectiveNoSpace
+}

cmd/nerdctl/network/network_create.go

@@ -42,6 +42,7 @@ func createCommand() *cobra.Command {
 	cmd.Flags().StringP("driver", "d", DefaultNetworkDriver, "Driver to manage the Network")
 	cmd.RegisterFlagCompletionFunc("driver", completion.NetworkDrivers)
 	cmd.Flags().StringArrayP("opt", "o", nil, "Set driver specific options")
+	cmd.RegisterFlagCompletionFunc("opt", completion.NetworkOptions)
 	cmd.Flags().String("ipam-driver", "default", "IP Address helpers.Management Driver")
 	cmd.RegisterFlagCompletionFunc("ipam-driver", completion.IPAMDrivers)
 	cmd.Flags().StringArray("ipam-opt", nil, "Set IPAM driver specific options")