Skip to content

Commit 1c6b79a

Browse files
committed
Clarify topology information for volume and snapshot
1 parent 0dbe605 commit 1c6b79a

File tree

3 files changed

+106
-82
lines changed

3 files changed

+106
-82
lines changed

csi.proto

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,11 @@ message CreateVolumeRequest {
243243
// If this field is not specified and the SP has the
244244
// VOLUME_ACCESSIBILITY_CONSTRAINTS plugin capability, the SP MAY
245245
// choose where the provisioned volume is accessible from.
246+
// When creating a volume from a snapshot, SP SHALL look at
247+
// accessibility_requirements in CreateVolumeRequest and
248+
// accessible_topology in CreateSnapshotResponse, and find an
249+
// intersection of the two. This intersection SHALL be reflected in
250+
// accessible_topology of CreateVolumeResponse.
246251
TopologyRequirement accessibility_requirements = 7;
247252
}
248253

@@ -1183,9 +1188,12 @@ message NodeGetInfoResponse {
11831188
// VOLUME_ACCESSIBILITY_CONSTRAINTS or
11841189
// SNAPSHOT_ACCESSIBILITY_CONSTRAINTS plugin capability.
11851190
// COs MAY use this information along with the topology information
1186-
// returned in CreateVolumeResponse CreateSnapshotResponse to ensure
1187-
// that a given volume or snapshot is accessible from a given node
1188-
// when scheduling workloads.
1191+
// returned in CreateVolumeResponse or CreateSnapshotResponse to
1192+
// ensure that a given volume or snapshot is accessible from a given
1193+
// node when scheduling workloads.
1194+
// For creating a volume from a snapshot, the topology information in
1195+
// CreateVolumeResponse is the intersection of topologies accessible
1196+
// by the volume and its source snapshot.
11891197
// This field is OPTIONAL. If it is not specified, the CO MAY assume
11901198
// the node is not subject to any topological constraint, and MAY
11911199
// schedule workloads that reference any volume V, such that there are

0 commit comments

Comments
 (0)