Skip to content

SqlParser can mark valid statements as invalid, preventing worker deployment #1633

Description

@whit0694

PR #1619 added a utility to parse user-defined queries.

At least in Oracle it's possible to have valid queries that fail validation, preventing us from creating the Connect worker

We have queries that work, but that we can not run EXPLAIN on, due to ORA-01039 errors.

The owners of the underlying views aren't going to change things to allow us to run EXPLAIN, so we're unable to deploy the worker.

Could we have the SqlParser be optional? In the original PR the stated goal of implementing the parser was to help people that have query.masked enabled. We don't use that feature, so maybe we could skip parsing unless query.masked is enabled?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions