Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25.1.0: conda_build.deprecations.DeprecatedError when executing commands #5587

Closed
2 tasks done
Tracked by #5578
OddBloke opened this issue Jan 14, 2025 · 6 comments
Closed
2 tasks done
Tracked by #5578
Assignees
Labels
in-progress issue is actively being worked on severity::1 blocker; broken functionality with no workaround source::community catch-all for issues filed by community members type::bug describes erroneous operation, use severity::* to classify the type type::deprecation requests removal of deprecated feature(s)
Milestone

Comments

@OddBloke
Copy link

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

We just attempted to build a new package from the 25.1.0 tag, and saw this error in our testing:

$ conda-build --help
Traceback (most recent call last):
  File "/usr/bin/conda-build", line 5, in <module>
    from conda_build.cli.main_build import execute
  File "/usr/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 19, in <module>
    from .. import api, build, source, utils
  File "/usr/lib/python3.10/site-packages/conda_build/api.py", line 24, in <module>
    from .config import DEFAULT_PREFIX_LENGTH as _prefix_length
  File "/usr/lib/python3.10/site-packages/conda_build/config.py", line 28, in <module>
    from .utils import (
  File "/usr/lib/python3.10/site-packages/conda_build/utils.py", line 70, in <module>
    from .exceptions import BuildLockError
  File "/usr/lib/python3.10/site-packages/conda_build/exceptions.py", line 50, in <module>
    class UnableToParseMissingJinja2(UnableToParse):
  File "/usr/lib/python3.10/site-packages/conda_build/deprecations.py", line 111, in deprecated_decorator
    raise DeprecatedError(message)
conda_build.deprecations.DeprecatedError: conda_build.exceptions.UnableToParseMissingJinja2 was slated for removal in 25.1.

This can be reproduced simply with python3 -c 'import conda_build.exceptions'

Conda Info

Conda Config

Conda list

Additional Context

No response

@OddBloke OddBloke added the type::bug describes erroneous operation, use severity::* to classify the type label Jan 14, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Jan 14, 2025
@OddBloke
Copy link
Author

This also appears to be the cause of the CI failure at https://github.com/conda/conda-build/actions/runs/12773009125/job/35603905717#step:5:1281

@kenodegard kenodegard self-assigned this Jan 14, 2025
@kenodegard kenodegard added in-progress issue is actively being worked on type::deprecation requests removal of deprecated feature(s) source::community catch-all for issues filed by community members labels Jan 14, 2025
@kenodegard kenodegard moved this from 🆕 New to 🏗️ In Progress in 🧭 Planning Jan 14, 2025
@kenodegard kenodegard added this to the 25.1.x milestone Jan 14, 2025
@kenodegard
Copy link
Contributor

@OddBloke thanks for bringing this to our attention, working on a fix, please use conda-build=24.11 in the meantime

@jezdez
Copy link
Member

jezdez commented Jan 15, 2025

Fixed via #5588

@jezdez jezdez closed this as completed Jan 15, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to 🏁 Done in 🧭 Planning Jan 15, 2025
@tkelman
Copy link
Contributor

tkelman commented Jan 15, 2025

Should removing deprecations be added to the release process or was this a case of tagging before noticing the tests failing?

@OddBloke
Copy link
Author

Thanks for the speedy resolution here! I can confirm that 25.1.1 went through our build and test pipelines without a hitch: wolfi-dev/os#39596

@kenodegard
Copy link
Contributor

@tkelman Should removing deprecations be added to the release process or was this a case of tagging before noticing the tests failing?

unsure what went wrong, we have opened #5590 to investigate further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress issue is actively being worked on severity::1 blocker; broken functionality with no workaround source::community catch-all for issues filed by community members type::bug describes erroneous operation, use severity::* to classify the type type::deprecation requests removal of deprecated feature(s)
Projects
Status: 🏁 Done
Development

No branches or pull requests

4 participants