Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-forge:: removed from environment.yaml #282

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

schuylermartin45
Copy link
Collaborator

pytest-socket is now widely available on both conda-forge and defaults, allowing us to make this change.

@schuylermartin45 schuylermartin45 requested a review from a team as a code owner January 6, 2025 16:26
@schuylermartin45
Copy link
Collaborator Author

The package on defaults appears to work. I added this:

    import requests
    requests.get("https://google.com")

to one of our test cases locally. The test failed with the socket exception, as anticipated.

@schuylermartin45
Copy link
Collaborator Author

NOTE: The integration testing failures are a known issue.

@schuylermartin45 schuylermartin45 merged commit 3e75998 into main Jan 6, 2025
12 of 13 checks passed
@schuylermartin45 schuylermartin45 deleted the smartin_pytest_socket_environment branch January 6, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants