244 bump recipe should exit and save gracefully on some failures #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould prevent future painful refactors
…r into 244-bump-recipe-should-exit-and-save-gracefully-on-some-failures
…: the new test takes an incredibly long time due to the issue tracked by #265
…o complete. I forgot to add the interval timer control for the retry mechanism in a purposefully failing test
|
Looks like rattler-build put out a new version last night, and that's causing some of the integration testing thresholds to fail. Will need to create a new issue to investigate, but this shouldn't be a blocker for this PR. There is no recipe conversion code being changed. |
|
I was about to as for that feature in private :) |
schuylermartin45
deleted the
244-bump-recipe-should-exit-and-save-gracefully-on-some-failures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
--save-on-failureflag tocrm bump-recipeto allow the tool to save partially upgraded files, in the event of an unrecoverable failure.Also simplifies adding future flags by introducing a
_CliArgsstruct to easily pass new flags into all necessary functions going forward.