Skip to content

Conversation

@VasanthakumarV
Copy link
Contributor

@VasanthakumarV VasanthakumarV commented Oct 15, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@VasanthakumarV VasanthakumarV marked this pull request as draft October 15, 2025 15:14
@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/codebook-lsp/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/codebook-lsp/recipe.yaml:

  • ❌ The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18533731810. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/codebook-lsp/recipe.yaml) and found it was in an excellent condition.

@VasanthakumarV VasanthakumarV force-pushed the codebook branch 8 times, most recently from 91e4412 to 3b7349a Compare October 15, 2025 17:39
@VasanthakumarV VasanthakumarV marked this pull request as ready for review October 15, 2025 17:53
@VasanthakumarV
Copy link
Contributor Author

@conda-forge/help-rust, ready for review

Copy link
Member

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use cargo-auditable.

I suggest you look at https://conda-forge.org/docs/maintainer/example_recipes/rust/

@VasanthakumarV
Copy link
Contributor Author

@conda-forge/help-rust PR ready for merge

Copy link
Contributor

@danielnachun danielnachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very small changes needed here and then this should be ready to go.

@VasanthakumarV
Copy link
Contributor Author

Hi @danielnachun, Thanks for the review, please do let me know if further changes are required.

@baszalmstra baszalmstra merged commit e988e53 into conda-forge:main Nov 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants