added pywebview - #34035
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pywebview/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/28606772067. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/28660003417. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/pywebview/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/32866310796. Examine the logs at this URL for more detail. |
|
Tried to contribute to this PR, but since the main contributor (@jaromieee ) has not shown any sign of activity in three weeks, I am pushing on my own PR. |
|
I accept to be listed as maintainer |
|
@conda-forge/help-python, ready for review! |
| - python: | ||
| imports: | ||
| - UniformTypeIdentifiers | ||
| - requirements: | ||
| run: | ||
| - pip | ||
| script: | ||
| - pip check |
There was a problem hiding this comment.
| - python: | |
| imports: | |
| - UniformTypeIdentifiers | |
| - requirements: | |
| run: | |
| - pip | |
| script: | |
| - pip check | |
| - python: | |
| imports: | |
| - UniformTypeIdentifiers | |
| python_version: | |
| - ${{ python_min }}.* | |
| - "*" | |
| pip_check: true |
There was a problem hiding this comment.
Removed the python_version section as testing it against python_min did not work since this package is non-noarch.
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Updated test configuration to include requirements and script for pip check. In order to test if that change broke the CI
Removed pip check requirement from tests and updated python version specifications.
Removed specific python version constraints from tests.
Add support for multiple Python versions in tests.
drop the python_version list for this non-noarch recipe — each variant should just be tested against its own build's python
|
@conda-forge/help-python, ready for review! |
| url: https://pypi.org/packages/source/p/pyobjc_framework_uniformtypeidentifiers/pyobjc_framework_uniformtypeidentifiers-${{ version }}.tar.gz | ||
| sha256: f7fe17832de25098b9ad7718af536f6f4597985418d9869946cee104e2782b8a | ||
|
|
||
| build: |
There was a problem hiding this comment.
Upstream shows that this package is pure Python.
I guess you can use noarch: python and add __osx >=11.0 to the run requirements?
The import tests can remain:
build:
noarch: python
requirements:
run:
- __osx >=11.0
tests:
- python:
imports:
- UniformTypeIdentifiers
pip_check: true
python_version:
- ${{ python_min }}.*
- "*"There was a problem hiding this comment.
@conda-forge/help-python, The CI might still fail, but this should be fine, right?
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).