Skip to content

added pywebview - #34035

Open
GaelTouquet wants to merge 48 commits into
conda-forge:mainfrom
GaelTouquet:pywebview
Open

added pywebview#34035
GaelTouquet wants to merge 48 commits into
conda-forge:mainfrom
GaelTouquet:pywebview

Conversation

@GaelTouquet

@GaelTouquet GaelTouquet commented Jul 2, 2026

Copy link
Copy Markdown

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pywebview/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/pywebview/recipe.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/28606772067. Examine the logs at this URL for more detail.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pywebview/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin

conda-forge-admin commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/28660003417. Examine the logs at this URL for more detail.

@conda-forge-admin

conda-forge-admin commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pywebview/recipe.yaml, recipes/pyobjc-framework-uniformtypeidentifiers/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pywebview/recipe.yaml:

  • ℹ️ The recipe sets python_min to 3.10, which is equal or lower than the default provided by conda-forge's global pinning. Please remove the redefinition.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/32866310796. Examine the logs at this URL for more detail.

@GaelTouquet

Copy link
Copy Markdown
Author

Tried to contribute to this PR, but since the main contributor (@jaromieee ) has not shown any sign of activity in three weeks, I am pushing on my own PR.

@GaelTouquet

Copy link
Copy Markdown
Author

I accept to be listed as maintainer

@GaelTouquet

Copy link
Copy Markdown
Author

@conda-forge/help-python, ready for review!

Comment thread recipes/pyobjc-framework-uniformtypeidentifiers/recipe.yaml Outdated
Comment thread recipes/pyobjc-framework-uniformtypeidentifiers/recipe.yaml Outdated
Comment on lines +33 to +40
- python:
imports:
- UniformTypeIdentifiers
- requirements:
run:
- pip
script:
- pip check

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- python:
imports:
- UniformTypeIdentifiers
- requirements:
run:
- pip
script:
- pip check
- python:
imports:
- UniformTypeIdentifiers
python_version:
- ${{ python_min }}.*
- "*"
pip_check: true

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the python_version section as testing it against python_min did not work since this package is non-noarch.

Comment thread recipes/pywebview/recipe.yaml Outdated
Comment thread recipes/pywebview/recipe.yaml Outdated
Comment thread recipes/pywebview/recipe.yaml Outdated
Comment thread recipes/pywebview/recipe.yaml Outdated
Comment thread recipes/pywebview/recipe.yaml Outdated
Comment thread recipes/pywebview/recipe.yaml Outdated
GaelTouquet and others added 18 commits August 24, 2026 08:17
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Updated test configuration to include requirements and script for pip check. In order to test if that change broke the CI
Removed pip check requirement from tests and updated python version specifications.
Removed specific python version constraints from tests.
Add support for multiple Python versions in tests.
drop the python_version list for this non-noarch recipe — each variant should just be tested against its own build's python
@GaelTouquet

Copy link
Copy Markdown
Author

@conda-forge/help-python, ready for review!

url: https://pypi.org/packages/source/p/pyobjc_framework_uniformtypeidentifiers/pyobjc_framework_uniformtypeidentifiers-${{ version }}.tar.gz
sha256: f7fe17832de25098b9ad7718af536f6f4597985418d9869946cee104e2782b8a

build:

@eunos-1128 eunos-1128 Aug 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream shows that this package is pure Python.

I guess you can use noarch: python and add __osx >=11.0 to the run requirements?

The import tests can remain:

build:
  noarch: python

requirements:
  run:
    - __osx >=11.0

tests:
  - python:
      imports:
        - UniformTypeIdentifiers
      pip_check: true
      python_version:
        - ${{ python_min }}.*
        - "*"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conda-forge/help-python, The CI might still fail, but this should be fine, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants