Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify codebase file organization #382

Closed
cpritcha opened this issue Aug 29, 2018 · 3 comments
Closed

Clarify codebase file organization #382

cpritcha opened this issue Aug 29, 2018 · 3 comments
Labels
high priority

Comments

@cpritcha
Copy link
Contributor

cpritcha commented Aug 29, 2018 •
edited
Loading

Sample code review run:

Test code reviews had some problems:

  • Uploaded models have data in the wrong place.

Possible Solutions:

  • Make model process instructions more clear about where data is located
  • Configurable data location
@alee alee changed the title Codebase Review - Reduce Difficulty of Code Review Clarify codebase file organization Nov 7, 2018
@alee
Copy link
Member

alee commented Nov 7, 2018

Consider always displaying the filesystem layout during the upload process

@alee
Copy link
Member

alee commented Nov 7, 2018

also need to clarify upload instructions

@alee
Copy link
Member

alee commented Aug 30, 2019

this is mostly addressed in the page descriptions, additional discussion can go into #457

@alee alee closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alee @cpritcha