File tree Expand file tree Collapse file tree
workspace/ralphs/improve-codebase Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -49,6 +49,10 @@ only when they land in a commit.
4949 both create ` summary = Text(no_wrap=True, overflow="ellipsis") ` then
5050 branch on count > 0 vs "waitingβ¦". Two subclasses only β already
5151 noted in coverage as not-worth-extracting.
52+ - (01f2f1c β dropped ` _FullscreenPeek._reset_view ` which had the same body
53+ as ` scroll_to_bottom ` .) No other near-duplicate scroll helpers spotted
54+ in that class; ` scroll_up ` / ` scroll_down ` / ` scroll_to_top ` each touch
55+ ` _auto_scroll ` under different conditions.
5256
5357## Phase 3 β magic values
5458
Original file line number Diff line number Diff line change 11# ` _console_emitter.py ` coverage
22
3- Valid at: ef9a178
3+ Valid at: 01f2f1c
44
55## Recent changes
66
7+ - 01f2f1c β dropped ` _FullscreenPeek._reset_view ` . Its body
8+ (` self._offset = 0; self._auto_scroll = True ` ) was byte-for-byte identical
9+ to ` scroll_to_bottom ` . The two call sites in ` _step_iteration ` now call
10+ ` scroll_to_bottom() ` directly; the "snap to newest line + follow" intent
11+ moved into a docstring on the surviving method. No other scroll-reset
12+ duplication remains.
713- ef9a178 β replaced the single cross-class ` _fullscreen_view._iteration_id `
814 access in ` _archive_current_iteration_unlocked ` with the public
915 ` iteration_id ` property on ` _FullscreenPeek ` . No behavior change β
Original file line number Diff line number Diff line change 22
33One line per iteration: ` <sha> <summary> ` .
44
5+ 01f2f1c refactor: drop ` _reset_view ` in ` _FullscreenPeek ` β identical body to ` scroll_to_bottom `
56ef9a178 refactor: replace ` _fullscreen_view._iteration_id ` cross-class private access with public ` iteration_id ` property
67c4469a1 refactor: extract ` _step_iteration ` to dedupe prev/next iteration browsing in ` _FullscreenPeek `
785337d88 refactor: drop redundant empty-dict guard in ` _format_categories ` β ` " Β· ".join([]) ` already returns ` "" `
You canβt perform that action at this time.
0 commit comments