Skip to content

Commit f94a1a3

Browse files
Kasper JungeRalphify
authored andcommitted
workspace: record _reset_view removal
Co-authored-by: Ralphify <noreply@ralphify.co>
1 parent 01f2f1c commit f94a1a3

3 files changed

Lines changed: 12 additions & 1 deletion

File tree

β€Žworkspace/ralphs/improve-codebase/backlog.mdβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ only when they land in a commit.
4949
both create `summary = Text(no_wrap=True, overflow="ellipsis")` then
5050
branch on count > 0 vs "waiting…". Two subclasses only β€” already
5151
noted in coverage as not-worth-extracting.
52+
- (01f2f1c β€” dropped `_FullscreenPeek._reset_view` which had the same body
53+
as `scroll_to_bottom`.) No other near-duplicate scroll helpers spotted
54+
in that class; `scroll_up` / `scroll_down` / `scroll_to_top` each touch
55+
`_auto_scroll` under different conditions.
5256

5357
## Phase 3 β€” magic values
5458

β€Žworkspace/ralphs/improve-codebase/coverage/_console_emitter.mdβ€Ž

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
11
# `_console_emitter.py` coverage
22

3-
Valid at: ef9a178
3+
Valid at: 01f2f1c
44

55
## Recent changes
66

7+
- 01f2f1c β€” dropped `_FullscreenPeek._reset_view`. Its body
8+
(`self._offset = 0; self._auto_scroll = True`) was byte-for-byte identical
9+
to `scroll_to_bottom`. The two call sites in `_step_iteration` now call
10+
`scroll_to_bottom()` directly; the "snap to newest line + follow" intent
11+
moved into a docstring on the surviving method. No other scroll-reset
12+
duplication remains.
713
- ef9a178 β€” replaced the single cross-class `_fullscreen_view._iteration_id`
814
access in `_archive_current_iteration_unlocked` with the public
915
`iteration_id` property on `_FullscreenPeek`. No behavior change β€”

β€Žworkspace/ralphs/improve-codebase/iterations.mdβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
One line per iteration: `<sha> <summary>`.
44

5+
01f2f1c refactor: drop `_reset_view` in `_FullscreenPeek` β€” identical body to `scroll_to_bottom`
56
ef9a178 refactor: replace `_fullscreen_view._iteration_id` cross-class private access with public `iteration_id` property
67
c4469a1 refactor: extract `_step_iteration` to dedupe prev/next iteration browsing in `_FullscreenPeek`
78
5337d88 refactor: drop redundant empty-dict guard in `_format_categories` β€” `" Β· ".join([])` already returns `""`

0 commit comments

Comments
Β (0)