Skip to content

Commit b496498

Browse files
committed
ENH: use log report as it happens comes later and rerunfailures uses it
1 parent 0609727 commit b496498

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

nbval/plugin.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -931,12 +931,11 @@ def _indent(s, indent=' '):
931931
skip_modules = []
932932

933933

934-
@pytest.hookimpl(trylast=True, hookwrapper=True)
935-
def pytest_runtest_makereport(item, call):
936-
outcome = yield
934+
@pytest.hookimpl(trylast=True)
935+
def pytest_runtest_logreport(report):
937936

938-
if outcome.get_result().failed:
939-
skip_modules.append(item.path)
937+
if 'failed' in report.outcome:
938+
skip_modules.append(report.fspath)
940939

941940

942941
def pytest_runtest_call(item):

0 commit comments

Comments
 (0)