Use a proper translation string for audit record types

Author: stevenrombauts

templates/audit_log/view_audit_logs.html.twig

@@ -20,7 +20,7 @@
                 {% for log in auditLogs %}
                     <tr>
                         <td>{{ log.datetime|date('Y-m-d H:i:s') }} UTC</td>
-                        <td data-test="audit-log-type">{{ log.type.value }}</td>
+                        <td data-test="audit-log-type">{{ ('audit_log.type.'~log.type.value)|trans }}</td>
                         <td>{{ log.vendor ?? '-' }}</td>
                     </tr>
                 {% endfor %}

tests/Controller/AuditLogControllerTest.php

@@ -24,10 +24,10 @@ public function testViewAuditLogs(): void
 
         $this->store($user, $package);
 
-        $auditLog1 = AuditRecord::canonicalUrlChange($package, $user, 'https://github.com/vendor1/package1-new');
-        $auditLog2 = AuditRecord::packageDeleted($package, $user);
+        $auditRecord1 = AuditRecord::canonicalUrlChange($package, $user, 'https://github.com/vendor1/package1-new');
+        $auditRecord = AuditRecord::packageDeleted($package, $user);
 
-        $this->store($auditLog1, $auditLog2);
+        $this->store($auditRecord1, $auditRecord);
 
         $this->client->loginUser($user);
         $crawler = $this->client->request('GET', '/audit-log');
@@ -36,9 +36,9 @@ public function testViewAuditLogs(): void
         $rows = $crawler->filter('[data-test=audit-log-type]');
         static::assertGreaterThanOrEqual(3, $rows->count(), 'Should have at least 3 audit log entries');
         static::assertSame([
-            'package_deleted',
-            'canonical_url_change',
-            'package_created',
+            'Package deleted',
+            'Canonical URL changed',
+            'Package created',
         ], $rows->each(fn ($element) => trim($element->text())));
     }
 }

translations/messages.en.yml

@@ -168,3 +168,11 @@ freezing_reasons:
     spam: This package was marked as spam and has been frozen as a result.
     remote_id: This package's canonical repository id has changed and the package has been frozen as a result. Email us for help if needed.
     gone: This package's canonical repository appears to be gone and the package has been frozen as a result. Email us for help if needed.
+
+audit_log:
+    type:
+        package_created: Package created
+        package_deleted: Package deleted
+        version_deleted: Version deleted
+        version_reference_change: Version reference changed
+        canonical_url_change: Canonical URL changed