-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion regarding the BDF solver #5
Comments
Hi @jiweiqi , Thanks for asking. I'm currently to trying to write a |
I just read the Jax PR. Regarding the slowness, you might take a look at the clipping and normalization of the mass fraction. Clipping and normalization of the mass fraction could affect the properties of the Jacobian matrix. This has been discussed somewhere else in the Cantera google group. For ReacTorch, we are working on fixing this issue. |
Thanks for the suggestion. I think this is what you are talking about https://github.com/comocheng/jax-reactor/blob/master/jax_reactor/solution.py#L79. I might be wrong but let me know!! |
Yes. Besides that, another clipping is in the wdot function jax-reactor/jax_reactor/solution.py Line 58 in e13d359
|
I am not sure if this is the case. An easy way to test it is to print out the number of function evaluations and jacobian evaluations. If you see significantly more computation than Cantera, then that is probably related to this issue. |
The BDF solver is really cool! I have a quick question regarding the AD of BDF solver.
Is it possible to use Auto-Differentiation across the BDF solver, so that we can do efficient adjoint sensitivity analysis?
For adjoint sensitivity analysis, we have the species concentrations
Y = F(t)
, and we define a loss functiong(Y)
and compute the gradient ofg(Y)
for optimizing the mechanism.The text was updated successfully, but these errors were encountered: