-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Description
β Have you read and understood the above guidelines?
yes
π What is the name of the script you are using?
post-pbs-install.sh
π What was the exact command used to execute the script?
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/tools/pve/post-pbs-install.sh)"
βοΈ What settings are you using?
- Default Settings
- Advanced Settings
π₯οΈ Which Linux distribution are you using?
Debian 13
π Which Proxmox version are you on?
Proxmox Backup Server 4.0.16 (per gui)
π Provide a clear and concise description of the issue.
When the script disables the enterprise repository, it does so by commenting the single "Components" line in "/etc/apt/source.list.d/pbs-enterprise.sources". This results in the apt command reporting "Error: Malformed entry 1 in sources file /etc/apt/sources.list.d/pbs-enteprise.sources (Component)".
My initial work around was to comment every line in the pbs-enterprise.sources file. This does get around the issue, but this has the side effect of completely removing the entry from the GUI's list of repositories.
When I uncommented every line in pbs-enterpise.sources and then used the GUI to disable the repository, the repository remained in the GUI display, but was flagged with "Enabled: false". I then reviewed the contents of pbs-enterprise.sources and discovered that the line "Enabled: false" had been added to the end of the file. This flag allows APT to ignore the source while still allowing PBS to discover and report the source in the GUI.
This script needs to be updated for PBS 4, to either comment the entire file or to add/update the "Enabled" flag within the file.
Note 1: If the "enabled" option is chosen, I believe the script should also use this technique when adding the disabled "pbs-test.sources" file. This would make the disabling method consistent between the two files.
Note 2: I did not upgrade an existing PBS 3 system. I installed PBS 4 on a fresh VM using the ISO found at "https://enterprise.proxmox.com/iso/proxmox-backup-server_4.0-1.iso"
π Steps to reproduce the issue.
Step 1: Install PBS 4.0 on clean system using the enterprise.proxmox.com/iso/proxmox-backup-server_4.0-1.iso file.
Step 2: In web browser (Firefox for me) open the PBS gui (accepting the self-signed certificate) and select the "Shell" menu item.
Step 3: In the shell paste the 'bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/tools/pve/post-pbs-install.sh)"' command.
Step 4: Choose "yes" to "Start the Proxmox Backup..." prompt.
Step 5: Choose "yes" to "Correct Debian sources..." prompt.
Step 6: Choose "yes" to "Enterprise repository detected." prompt.
Step 7: Choose "yes" to "Disable subscription nag..." prompt.
Step 8: Choose "yes" to "Update Proxmox Backup Server now" prompt.
Step 9: Choose "no" to "Reboot..." prompt.
Notice the "apt update failed" and "apt dist-upgrade failed" messages. Review of /etc/apt/sources.list/pbs-enterprise.sources show single line commented.
β Paste the full error output (if available).
____ ____ _____ ____ __ ____ __ ____
/ __ \/ __ ) ___/ / __ \____ _____/ /_ / _/___ _____/ /_____ _/ / /
/ /_/ / __ \__ \ / /_/ / __ \/ ___/ __/ / // __ \/ ___/ __/ __ `/ / /
/ ____/ /_/ /__/ / / ____/ /_/ (__ ) /_ _/ // / / (__ ) /_/ /_/ / / /
/_/ /_____/____/ /_/ \____/____/\__/ /___/_/ /_/____/\__/\__,_/_/_/
β Corrected Debian Sources
β Disabled 'pbs-enterprise' repository
β Added 'pbs-no-subscription' repository
β Added 'pbs-test' repository (disabled)
β Disabled subscription nag (clear browser cache!)
β Widget toolkit reinstall failed
β apt update failed
β apt dist-upgrade failed
β Updated Proxmox Backup Server
β Selected no to Reboot (Reboot recommended)
β Completed Post Install Routines
πΌοΈ Additional context (optional).
Invalid pbs-enterprise.sources file:
Types: deb
URIs: https://enterprise.proxmox.com/debian/pbs
Suites: trixie
# Components: pbs-enterprise
Signed-By: /usr/share/keyrings/proxmox-archive-keyring.gpg
Valid pbs-enterprise.sources file:
Types: deb
URIs: https://enterprise.proxmox.com/debian/pbs
Suites: trixie
Components: pbs-enterprise
Signed-By: /usr/share/keyrings/proxmox-archive-keyring.gpg
Enabled: false