Skip to content

Mention why we don't use pydantic in FAQ #1488

Open
@bearomorphism

Description

@bearomorphism

I guess I misinterpreted the ticket. I thought it was creating an issue on a downstream project.
My point is that a ticket is a burden on (volunteer) maintainers. Because we pin dependencies, if users add commitizen as a dev-dependency, we limit what they can install. pydantic is a widely used dependency, we would have to rush into supporting v3 (depending on how we pin it). This PR doesn't make use of much iterfaces from pydantic, but by having it available, we are telling other contributors: yes, you can use the full pydantic featureset. It's a long term issue FMPOV
This would be a clearer issue: #1249

You're right. I intention of this PR was that I just wanted a more strict type for Questions. The runtime check is not needed.

Let me close this PR and use TypedDIct to address the issue.

Maybe we could mention this in our FAQ as well 🤔

Originally posted by @Lee-W in #1467 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions