Skip to content

Commit 1c0fad8

Browse files
committed
#441: Enable disabled tests.
1 parent 4256d26 commit 1c0fad8

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/test/java/com/commercetools/sync/products/helpers/ProductBatchProcessorTest.java

-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import io.sphere.sdk.products.ProductVariantDraftBuilder;
1313
import io.sphere.sdk.products.attributes.AttributeDraft;
1414
import org.junit.jupiter.api.BeforeEach;
15-
import org.junit.jupiter.api.Disabled;
1615
import org.junit.jupiter.api.Test;
1716

1817
import java.util.ArrayList;
@@ -325,7 +324,6 @@ void getProductKeyFromReference_WithoutAProductReference_ShouldReturnEmptyOpt()
325324
assertThat(result).isEmpty();
326325
}
327326

328-
@Disabled("Fails due to bug on https://github.com/FasterXML/jackson-databind/issues/2442")
329327
@Test
330328
void getReferencedProductKeysFromSet_WithOnlyNullRefsInSet_ShouldReturnEmptySet() {
331329
final AttributeDraft productReferenceSetAttribute =

src/test/java/com/commercetools/sync/products/helpers/VariantReferenceResolverTest.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import io.sphere.sdk.types.CustomFieldsDraft;
2525
import io.sphere.sdk.utils.MoneyImpl;
2626
import org.junit.jupiter.api.BeforeEach;
27-
import org.junit.jupiter.api.Disabled;
2827
import org.junit.jupiter.api.Test;
2928

3029
import java.math.BigDecimal;
@@ -334,7 +333,6 @@ void resolveReferences_WithMixedReferences_ShouldResolveReferenceAttributes() {
334333
.isEqualTo(Customer.referenceTypeId());
335334
}
336335

337-
@Disabled("Fails due to possible bug on https://github.com/FasterXML/jackson-databind/issues/2442")
338336
@Test
339337
void resolveReferences_WithNullReferenceInSetAttribute_ShouldResolveReferences() {
340338
// preparation
@@ -370,7 +368,7 @@ void resolveReferences_WithNullReferenceInSetAttribute_ShouldResolveReferences()
370368
final ObjectNode resolvedReference = JsonNodeFactory.instance.objectNode();
371369
resolvedReference.put(REFERENCE_TYPE_ID_FIELD, Product.referenceTypeId());
372370
resolvedReference.put(REFERENCE_ID_FIELD, PRODUCT_ID);
373-
assertThat(resolvedSet).containsExactly(resolvedReference);
371+
assertThat(resolvedSet).containsExactlyInAnyOrder(resolvedReference, JsonNodeFactory.instance.nullNode());
374372
}
375373

376374
@Test

0 commit comments

Comments
 (0)