Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in the dataframe column names #71

Open
tnzmnjm opened this issue May 15, 2024 · 1 comment
Open

Consistency in the dataframe column names #71

tnzmnjm opened this issue May 15, 2024 · 1 comment

Comments

@tnzmnjm
Copy link
Collaborator

tnzmnjm commented May 15, 2024

We have a mix of column names with underscores for separators between words (e.g. base_repo_url) and other names that are simply joined into a long word (e.g. testfilecountlocal). We need to consistent.

@julianharty
Copy link
Member

Let's also see how we can revise the names so they communicate their purpose clearly e.g. base_repo_url_flag is unnecessarily vague, a more purposeful name might be: base_repo_url_extracted_successfully; and I suspect we might devise even clearer names.

As a historical note, Hungarian Notation was once used extensively and it uses a prefix of f to indicate the data type is a flag. Hungarian Notation is not recommended by many people these days; and especially not recommended in python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants