From 5e6b65b02a84cf25062661c28434063392168c37 Mon Sep 17 00:00:00 2001
From: massifben <105049157+massifben@users.noreply.github.com>
Date: Tue, 14 Jan 2025 12:25:50 +0100
Subject: [PATCH] fix(#449): fix test in LNodeStatusServiceTest

Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>
---
 .../sct/commons/LNodeStatusServiceTest.java   | 22 +++++---
 .../resources/scl-lnodestatus/lnodestatus.scd | 54 ++++++++++++++++---
 2 files changed, 61 insertions(+), 15 deletions(-)

diff --git a/sct-commons/src/test/java/org/lfenergy/compas/sct/commons/LNodeStatusServiceTest.java b/sct-commons/src/test/java/org/lfenergy/compas/sct/commons/LNodeStatusServiceTest.java
index d988862f1..505431be5 100644
--- a/sct-commons/src/test/java/org/lfenergy/compas/sct/commons/LNodeStatusServiceTest.java
+++ b/sct-commons/src/test/java/org/lfenergy/compas/sct/commons/LNodeStatusServiceTest.java
@@ -48,14 +48,20 @@ void updateLnStatusBasedOnPrivateLNodeStatus_should_update_Mod_stVal(String ldIn
 
     public static Stream<Arguments> provideUpdateModStVal() {
         return Stream.of(
-                Arguments.of(named("LN 'on' à mettre à 'on'", "LDEVICE_1"), "PDIS", "1", "on"),
-                Arguments.of(named("LN 'off;on' à mettre à 'on'", "LDEVICE_1"), "PDIS", "2", "on"),
-                Arguments.of(named("LN 'off' à mettre à 'off'", "LDEVICE_1"), "PDIS", "3", "off"),
-                Arguments.of(named("LN 'off;on' à mettre à 'off'", "LDEVICE_1"), "PDIS", "3", "off"),
-                Arguments.of(named("LN0 'on' à mettre à 'on'", "LDEVICE_1"), "LLN0", "", "on"),
-                Arguments.of(named("LN0 'off;on' à mettre à 'on'", "LDEVICE_2"), "LLN0", "", "on"),
-                Arguments.of(named("LN0 'off' à mettre à 'off'", "LDEVICE_3"), "LLN0", "", "off"),
-                Arguments.of(named("LN0 'off;on' à mettre à 'off'", "LDEVICE_4"), "LLN0", "", "off")
+                // Tests on LN
+                Arguments.of(named("LN 'on;off' to set to 'on'", "LDEVICE_1"), "PDIS", "1", "on"),
+                Arguments.of(named("LN 'off;on' to set to 'on'", "LDEVICE_1"), "PDIS", "2", "on"),
+                Arguments.of(named("LN 'on' to set to 'on'", "LDEVICE_1"), "PDIS", "3", "on"),
+                Arguments.of(named("LN 'on;off' to set to 'off'", "LDEVICE_1"), "PDIS", "4", "off"),
+                Arguments.of(named("LN 'off;on' to set to 'off'", "LDEVICE_1"), "PDIS", "5", "off"),
+                Arguments.of(named("LN 'off' to set to 'off'", "LDEVICE_1"), "PDIS", "6", "off"),
+                // Tests on LN0
+                Arguments.of(named("LN0 'on;off' to set to 'on'", "LDEVICE_1"), "LLN0", "", "on"),
+                Arguments.of(named("LN0 'off;on' to set to 'on'", "LDEVICE_2"), "LLN0", "", "on"),
+                Arguments.of(named("LN0 'on' to set to 'on'", "LDEVICE_3"), "LLN0", "", "on"),
+                Arguments.of(named("LN0 'on;off' to set to 'off'", "LDEVICE_4"), "LLN0", "", "off"),
+                Arguments.of(named("LN0 'off;on' to set to 'off'", "LDEVICE_5"), "LLN0", "", "off"),
+                Arguments.of(named("LN0 'off' to set to 'off'", "LDEVICE_6"), "LLN0", "", "off")
         );
     }
 
diff --git a/sct-commons/src/test/resources/scl-lnodestatus/lnodestatus.scd b/sct-commons/src/test/resources/scl-lnodestatus/lnodestatus.scd
index 120833d95..6ff6a8e6f 100644
--- a/sct-commons/src/test/resources/scl-lnodestatus/lnodestatus.scd
+++ b/sct-commons/src/test/resources/scl-lnodestatus/lnodestatus.scd
@@ -20,11 +20,17 @@
                         <Private type="COMPAS-LNodeStatus">on</Private>
                     </LNode>
                     <LNode iedName="IED_NAME_1" ldInst="LDEVICE_1" lnClass="PDIS" lnInst="3">
-                        <Private type="COMPAS-LNodeStatus">off</Private>
+                        <Private type="COMPAS-LNodeStatus">on</Private>
                     </LNode>
                     <LNode iedName="IED_NAME_1" ldInst="LDEVICE_1" lnClass="PDIS" lnInst="4">
                         <Private type="COMPAS-LNodeStatus">off</Private>
                     </LNode>
+                    <LNode iedName="IED_NAME_1" ldInst="LDEVICE_1" lnClass="PDIS" lnInst="5">
+                        <Private type="COMPAS-LNodeStatus">off</Private>
+                    </LNode>
+                    <LNode iedName="IED_NAME_1" ldInst="LDEVICE_1" lnClass="PDIS" lnInst="6">
+                        <Private type="COMPAS-LNodeStatus">off</Private>
+                    </LNode>
                 </Function>
                 <Function name="FUNCTION_2">
                     <LNode iedName="IED_NAME_1" ldInst="LDEVICE_1" lnClass="LLN0">
@@ -34,11 +40,17 @@
                         <Private type="COMPAS-LNodeStatus">on</Private>
                     </LNode>
                     <LNode iedName="IED_NAME_1" ldInst="LDEVICE_3" lnClass="LLN0">
-                        <Private type="COMPAS-LNodeStatus">off</Private>
+                        <Private type="COMPAS-LNodeStatus">on</Private>
                     </LNode>
                     <LNode iedName="IED_NAME_1" ldInst="LDEVICE_4" lnClass="LLN0">
                         <Private type="COMPAS-LNodeStatus">off</Private>
                     </LNode>
+                    <LNode iedName="IED_NAME_1" ldInst="LDEVICE_5" lnClass="LLN0">
+                        <Private type="COMPAS-LNodeStatus">off</Private>
+                    </LNode>
+                    <LNode iedName="IED_NAME_1" ldInst="LDEVICE_6" lnClass="LLN0">
+                        <Private type="COMPAS-LNodeStatus">off</Private>
+                    </LNode>
                 </Function>
             </Bay>
         </VoltageLevel>
@@ -49,7 +61,7 @@
                 <Authentication/>
                 <LDevice inst="LDEVICE_1">
                     <LN0 lnType="lnType1" lnClass="LLN0" inst="">
-                        <Private type="COMPAS-LNodeStatus">on</Private>
+                        <Private type="COMPAS-LNodeStatus">on;off</Private>
                         <DOI name="Mod">
                             <DAI name="stVal"/>
                         </DOI>
@@ -61,18 +73,30 @@
                         </DOI>
                     </LN>
                     <LN lnType="lnType2" lnClass="PDIS" inst="2">
-                        <Private type="COMPAS-LNodeStatus">on</Private>
+                        <Private type="COMPAS-LNodeStatus">off;on</Private>
                         <DOI name="Mod">
                             <DAI name="stVal"/>
                         </DOI>
                     </LN>
                     <LN lnType="lnType2" lnClass="PDIS" inst="3">
-                        <Private type="COMPAS-LNodeStatus">on;off</Private>
+                        <Private type="COMPAS-LNodeStatus">on</Private>
                         <DOI name="Mod">
                             <DAI name="stVal"/>
                         </DOI>
                     </LN>
                     <LN lnType="lnType2" lnClass="PDIS" inst="4">
+                        <Private type="COMPAS-LNodeStatus">on;off</Private>
+                        <DOI name="Mod">
+                            <DAI name="stVal"/>
+                        </DOI>
+                    </LN>
+                    <LN lnType="lnType2" lnClass="PDIS" inst="5">
+                        <Private type="COMPAS-LNodeStatus">off;on</Private>
+                        <DOI name="Mod">
+                            <DAI name="stVal"/>
+                        </DOI>
+                    </LN>
+                    <LN lnType="lnType2" lnClass="PDIS" inst="6">
                         <Private type="COMPAS-LNodeStatus">off</Private>
                         <DOI name="Mod">
                             <DAI name="stVal"/>
@@ -81,7 +105,7 @@
                 </LDevice>
                 <LDevice inst="LDEVICE_2">
                     <LN0 lnType="lnType1" lnClass="LLN0" inst="">
-                        <Private type="COMPAS-LNodeStatus">on</Private>
+                        <Private type="COMPAS-LNodeStatus">off;on</Private>
                         <DOI name="Mod">
                             <DAI name="stVal"/>
                         </DOI>
@@ -89,13 +113,29 @@
                 </LDevice>
                 <LDevice inst="LDEVICE_3">
                     <LN0 lnType="lnType1" lnClass="LLN0" inst="">
-                        <Private type="COMPAS-LNodeStatus">on;off</Private>
+                        <Private type="COMPAS-LNodeStatus">on</Private>
                         <DOI name="Mod">
                             <DAI name="stVal"/>
                         </DOI>
                     </LN0>
                 </LDevice>
                 <LDevice inst="LDEVICE_4">
+                    <LN0 lnType="lnType1" lnClass="LLN0" inst="">
+                        <Private type="COMPAS-LNodeStatus">on;off</Private>
+                        <DOI name="Mod">
+                            <DAI name="stVal"/>
+                        </DOI>
+                    </LN0>
+                </LDevice>
+                <LDevice inst="LDEVICE_5">
+                    <LN0 lnType="lnType1" lnClass="LLN0" inst="">
+                        <Private type="COMPAS-LNodeStatus">off;on</Private>
+                        <DOI name="Mod">
+                            <DAI name="stVal"/>
+                        </DOI>
+                    </LN0>
+                </LDevice>
+                <LDevice inst="LDEVICE_6">
                     <LN0 lnType="lnType1" lnClass="LLN0" inst="">
                         <Private type="COMPAS-LNodeStatus">off</Private>
                         <DOI name="Mod">