Proposal to improve mill init support for importing projects using other build tools
#4726
Closed
ajaychandran
started this conversation in
Development
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Some suggestions to improve the implementations added in #3756, #4363, #4586.
General
BuildGenUtil.buildFilesto discard files based on name and not just extension. This is to avoid accidental re-formatting of, say,*.scscripts in a project.gitto set up the workspace inBuildGenTestSuite.integrationTest. This better emulates real world usage and avoids the copying in the current implementation.SBT
sbtOptions: mainargs.Leftover[String]toSbtBuildGenMain.Config. Among other benefits,MillInitSbtUtils.bumpSbtcan be replaced with--sbt-version <version>.apply-script-sideloading approach should eliminate the platform specific load.Perhaps these can be handled in 2 separate PRs?
Beta Was this translation helpful? Give feedback.
All reactions