Skip to content

Commit 7a28368

Browse files
authored
fix: windows installer can't be uninstalled (#320)
Updates our WiX template to fix an issue where dbc can't be uninstalled with Add/Remove programs. We were setting two values in our .wxs template incorrectly. The "Product Code" should vary between releases and the "Package Code" should as well. See: - https://learn.microsoft.com/en-us/windows/win32/msi/productcode - https://learn.microsoft.com/en-us/windows/win32/msi/package-codes Closes #319
1 parent dbbe734 commit 7a28368

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

resources/dbc.wxs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,11 @@ limitations under the License.
4848
<Publish Dialog="MaintenanceTypeDlg" Control="Back" Event="NewDialog" Value="MaintenanceWelcomeDlg">1</Publish>
4949
</UI>
5050
</Fragment>
51-
<Product Id="5B742771-61E1-4DC1-9276-6E1287282B3F" Name="dbc"
51+
<Product Id="*" Name="dbc" Language="1033"
5252
Manufacturer="Columnar Technologies Inc." Version="{{ .Version }}"
5353
UpgradeCode="3BC2470F-54EE-47F0-973C-A789684BF95E">
5454

55-
<Package Id="C72A9A3A-3BDE-43A3-BBDA-4AD8FFEDC819"
56-
InstallScope="perUser"
55+
<Package InstallScope="perUser"
5756
Keywords="Installer" Description="dbc Installer"
5857
Comments="ADBC is awesome" Manufacturer="Columnar Technologies Inc."
5958
InstallerVersion="200" Compressed="yes" SummaryCodepage='1252' />

0 commit comments

Comments
 (0)