Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volto-subblocks is not included as dependency #50

Closed
sneridagh opened this issue Nov 13, 2022 · 2 comments · Fixed by #49
Closed

volto-subblocks is not included as dependency #50

sneridagh opened this issue Nov 13, 2022 · 2 comments · Fixed by #49

Comments

@sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh linked a pull request Nov 13, 2022 that will close this issue
@pnicolli
Copy link
Member

volto-subblocks is a peer dependency as of 3.0.0, and needs to be installed together with this add-on as mentioned in the Readme. The rationale behind this is in #45.
I understand that this probably needs to be documented better in the changelog, or at least in the github release. I will try to take some time to have a better look at conventional commits and automatic changelog stuff which has been introduced here.

@sneridagh
Copy link
Member Author

sneridagh commented Nov 14, 2022

I see, and I understand the rationale. What I cannot do still is getting my head around peerDependencies.

Why setting volto-subblocks as a peerDependency, but not @hcaptcha/react-hcaptcha... Also, how the ecosystem treats peerDependencies (without breaking the install) is not the best. For sure, if we start using pnp and other installers then it will make sense, but unfortunately we are there yet as we need to go a long way before. Problem is that when installing Volto itself throws a thousand of peerDepencencies warnings, and this special one gets buried between them.

Anyways, as you said it would be great if this gets documented better. Also, I came around updating to 3.0.0 because using yarn3 the series 2 versions of volto-subblocks 2 was breaking because of the tag checksum. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants