Skip to content

Conversation

@c-nixon
Copy link
Contributor

@c-nixon c-nixon commented Sep 29, 2020

Implement AsRawFd for JournalRef as it is for BusRef.

The immediate use case is to allow asynchronous polling for events

Copy link
Owner

@codyps codyps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 5, 2020
138: Implement AsRawFd for JournalRef r=jmesmon a=c-nixon

Implement AsRawFd for JournalRef as it is for BusRef.

The immediate use case is to allow asynchronous polling for events

Co-authored-by: Chris Nixon <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 5, 2020

Build failed:

@codyps
Copy link
Owner

codyps commented Oct 5, 2020

Looks like this is nightly junk unrelated to this PR. I'll try to take a look this afternoon (and perhaps look at making nightly builds non-fatal but still warn us somewhere), though if someone else has a separate PR to resolve I won't turn it down.

@codyps
Copy link
Owner

codyps commented Oct 5, 2020

#141 should fix the nightly issue here

@codyps
Copy link
Owner

codyps commented Oct 5, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 5, 2020

Build succeeded:

  • check
  • continuous-integration/travis-ci/push

@bors bors bot merged commit 8081817 into codyps:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants