Provide "hook" after file generation

[svenjacobs]

First of all thanks for this great library! 👏🏼

It would be nice to be able to configure a "hook" or command which is executed after typesafe-i18n has created / updated the generated files. For example I would like to format these files with Prettier according to my projects code formatting rules.

The hook / command could be configured in .typesafe-i18n.json for instance.

[ivanhofer]

@svenjacobs sounds like a gread addition!
How would you expect to configure this?

Like this where you specify the command that then get's executed 1:1 in a childProcess?

{
   "runOnGeneratorEnd": "npm run prettier"
}

[svenjacobs]

Yes, this would be absolutely fine for my use case 👍🏼

[ivanhofer]

implemented in version 4.2.0

find the docs here

[ivanhofer]

never mind, thanks for helping identifying the bug :)

[svenjacobs]

You're welcome 🙂

[svenjacobs]

Hey, it's me again, unfortunately 😉

It seems I'm now actually running into the timeout issue. Sometimes after Prettier finished, changes are detected again which causes regeneration of files which in turn executes Prettier again. This sometimes happens two, three times in a row.

When increasing the timeout to 2000ms in cli/typesafe-i18n.mjs this does not happen.

Instead of a timeout, couldn't you use a boolean flag? Something like skipNextChangeDetection which is set to true in runCommandAfterGenerator() before the execSync() call and which is set to false in the Chokidar callback?

[ivanhofer]

Sorry to hear that.

That's exactly what I do ^^ + the additional 1000ms timeout to account for possible chokidar hickups.

1. changes are detected
2. 100ms waiting if another change was triggered
3. disable change detection
4. start generation of files
5. run custom runAfterGenerator command
6. wait 1000ms
7. enable change detection

That's also why it seemd odd to me that the solution we found before was actually working until now.

I found a place in the code that could be an issue.
Please try it with version 4.3.4 and let me know if it helps. But I don't think this will be the correct solution.

Maybe I should try to replace chokidar with something more "modern" and lightweight like https://github.com/lukeed/watchlist

[svenjacobs]

It seems that the latest fix has solved this problem. Thank you! 😃