Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate update to Nim 2.x #1010

Closed
gmega opened this issue Nov 27, 2024 · 8 comments
Closed

Evaluate update to Nim 2.x #1010

gmega opened this issue Nov 27, 2024 · 8 comments
Assignees
Labels
Client See https://miro.com/app/board/uXjVNZ03E-c=/ for details

Comments

@gmega
Copy link
Member

gmega commented Nov 27, 2024

With gc:refc at first.

@gmega gmega added the Client See https://miro.com/app/board/uXjVNZ03E-c=/ for details label Nov 27, 2024
@2-towns
Copy link
Contributor

2-towns commented Nov 28, 2024

I will create subtasks to ensure clear tracking of comments, as I believe we will have many comments.

@2-towns
Copy link
Contributor

2-towns commented Dec 2, 2024

I updated constantine dependency to the last commit hash because there is a compilation error with Nim 2.X.

Additionally, I updated the PR created by Ben for GCC 14 on nim-poseidon2 to reflect this change.

@2-towns
Copy link
Contributor

2-towns commented Dec 2, 2024

There is a problem with the default SAT resolver of nimble; it fails when trying to install dependencies; see vacp2p/nim-libp2p#1219.

I will use nimble --solver:legacy install until it is fixed.

@2-towns
Copy link
Contributor

2-towns commented Dec 5, 2024

With gc:refc at first.

It became mm:refc (https://nim-lang.org/docs/mm.html).

@2-towns
Copy link
Contributor

2-towns commented Dec 12, 2024

Contributions to sub-dependencies:

Found issue in nim-results:

arnetheduck/nim-results#50

Contribute to nim-testutils to fix case:

status-im/nim-testutils#54

@2-towns
Copy link
Contributor

2-towns commented Dec 12, 2024

I disabled for now the thread analysis using --threadAnalysis:off

@2-towns
Copy link
Contributor

2-towns commented Jan 7, 2025

When trying to update nim-nat-transversal, it wasn't working on Windows in CI.

I explored the issue in depth and found that it occurred due to upgrading miniupnp from version 2.2.4 to 2.2.5. The reason for this can be traced to this commit. It created a symbolic link inside the repository, and Windows handles symbolic links with Git very poorly.

The solution seems simple: apply git config --global core.symlinks false before fetching the submodules for Windows only.

@2-towns
Copy link
Contributor

2-towns commented Jan 7, 2025

I updated to Nim 2.0.14.

@2-towns 2-towns closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client See https://miro.com/app/board/uXjVNZ03E-c=/ for details
Projects
None yet
Development

No branches or pull requests

2 participants