feat: add order parameter in events controller #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
requested review from
Afonso-santos,
MarioRodrigues10,
ruilopesm and
ruioliveira02
|
AI-Generated Summary: This pull request introduces a new feature to the 'events' controller by adding an 'order' parameter. The 'list_events' function now checks whether this 'order' parameter is set to 'asc'. If it is, it returns all events ordered by 'start_time' in ascending order. If not, it returns all events ordered by 'start_time' in descending order. This change adds flexibility to how events are returned and should improve the user experience. |
danielsp45
force-pushed
the
dp/add-order-parameter
branch
from
23552c3 to
9268fc5
Compare
danielsp45
force-pushed
the
dp/add-order-parameter
branch
from
9268fc5 to
4271911
Compare
pedrofp4444
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Looks great to me! It works perfectly with the corresponding PR on shuriken. 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.