feat: support non-legal identifiers in field property names (#29)

* feat: support non-legal identifiers in field property names

Quoted string literals are allowed to be field property names. This
supports non-legal identifiers. Things like hyphenated field names.

Author: Emyrk

convert.go

@@ -679,7 +679,7 @@ func (ts *Typescript) buildStruct(obj types.Object, st *types.Struct) (*bindings
 		// Use the json name if present
 		jsonTag, err := tags.Get("json")
 		if err == nil {
-			if jsonTag.Name == "-" {
+			if jsonTag.Name == "-" && len(jsonTag.Options) == 0 {
 				// Completely ignore this field.
 				continue
 			}

testdata/nonids/nonids.go

@@ -0,0 +1,9 @@
+package nonids
+
+type Foo struct {
+	// Hyphen is an odd case, but this field is not ignored
+	Hyphen     string `json:"-,"`
+	Ignored    string `json:"-"`
+	Hyphenated string `json:"hyphenated-string"`
+	Numbered   int    `json:"1numbered"`
+}

testdata/nonids/nonids.ts

@@ -0,0 +1,8 @@
+// Code generated by 'guts'. DO NOT EDIT.
+
+// From nonids/nonids.go
+export interface Foo {
+    readonly "-": string;
+    readonly "hyphenated-string": string;
+    readonly "1numbered": number;
+}

typescript-engine/dist/main.js

@@ -11,7 +11,7 @@
 // https://astexplorer.net/
 
 import * as ts from "typescript";
-import { Modifier, ModifierSyntaxKind } from "typescript";
+import {Identifier, Modifier, ModifierSyntaxKind, StringLiteral} from "typescript";
 
 type modifierKeys = FilterKeys<typeof ts.SyntaxKind, ModifierSyntaxKind>;
 export function modifier(name: modifierKeys | ts.Modifier): Modifier {
@@ -28,6 +28,7 @@ export function identifier(name: string | ts.Identifier): ts.Identifier {
   if (typeof name !== "string") {
     return name;
   }
+
   return ts.factory.createIdentifier(name);
 }
 
@@ -37,9 +38,20 @@ export function propertySignature(
   question: boolean,
   type: ts.TypeNode
 ): ts.PropertySignature {
+
+  var id: Identifier | StringLiteral = identifier(name);
+
+  // Property names can be quoted if they are not valid identifiers.
+  // This is things like hyphens, numbers first, etc.
+  // TODO: If this regex exists in the typescript compiler, use that instead.
+  if(!(/^[A-Za-z_$][A-Za-z0-9_$]*$/.test(name))) {
+    id = ts.factory.createStringLiteral(name);
+  }
+
+
   return ts.factory.createPropertySignature(
     modifiers?.map((m) => modifier(m)),
-    identifier(name),
+    id,
     question ? questionToken() : undefined,
     type
   );