Skip to content

Commit fe7db49

Browse files
authored
Update values.yaml to better support dind (#7431)
1 parent 84728f0 commit fe7db49

File tree

2 files changed

+34
-16
lines changed

2 files changed

+34
-16
lines changed

ci/helm-chart/values.yaml

Lines changed: 31 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,9 @@ extraArgs: []
7575
extraVars: []
7676
# - name: DISABLE_TELEMETRY
7777
# value: "true"
78+
# if dind is desired:
7879
# - name: DOCKER_HOST
79-
# value: "tcp://localhost:2375"
80+
# value: "tcp://localhost:2376"
8081

8182
##
8283
## Init containers parameters:
@@ -139,25 +140,39 @@ lifecycle:
139140
# - -c
140141
# - curl -s -L SOME_SCRIPT | bash
141142

143+
# for dind, the following may be helpful
144+
# postStart:
145+
# exec:
146+
# command:
147+
# - /bin/sh
148+
# - -c
149+
# - |
150+
# sudo apt-get update \
151+
# && sudo apt-get install -y docker.io
152+
142153
## Enable an Specify container in extraContainers.
143154
## This is meant to allow adding code-server dependencies, like docker-dind.
144155
extraContainers: |
145156
# If docker-dind is used, DOCKER_HOST env is mandatory to set in "extraVars"
146-
#- name: docker-dind
147-
# image: docker:19.03-dind
148-
# imagePullPolicy: IfNotPresent
149-
# resources:
150-
# requests:
151-
# cpu: 250m
152-
# memory: 256M
153-
# securityContext:
154-
# privileged: true
155-
# procMount: Default
156-
# env:
157-
# - name: DOCKER_TLS_CERTDIR
158-
# value: ""
159-
# - name: DOCKER_DRIVER
160-
# value: "overlay2"
157+
# - name: docker-dind
158+
# image: docker:28.3.2-dind
159+
# imagePullPolicy: IfNotPresent
160+
# resources:
161+
# requests:
162+
# cpu: 1
163+
# ephemeral-storage: "50Gi"
164+
# memory: 10Gi
165+
# securityContext:
166+
# privileged: true
167+
# procMount: Default
168+
# env:
169+
# - name: DOCKER_TLS_CERTDIR
170+
# value: "" # disable TLS setup
171+
# command:
172+
# - dockerd
173+
# - --host=unix:///var/run/docker.sock
174+
# - --host=tcp://0.0.0.0:2376
175+
161176

162177
extraInitContainers: |
163178
# - name: customization

docs/FAQ.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,9 @@ mount into `/home/coder/myproject` from inside the `code-server` container. You
383383
need to make sure the Docker daemon's `/home/coder/myproject` is the same as the
384384
one mounted inside the `code-server` container, and the mount will work.
385385

386+
If you want Docker enabled when deploying on Kubernetes, look at the `values.yaml`
387+
file for the 3 fields: `extraVars`, `lifecycle.postStart`, and `extraContainers`.
388+
386389
## How do I disable telemetry?
387390

388391
Use the `--disable-telemetry` flag to disable telemetry.

0 commit comments

Comments
 (0)