Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol version check to use minor version also #188

Open
emilsoman opened this issue Jul 17, 2015 · 0 comments
Open

Fix protocol version check to use minor version also #188

emilsoman opened this issue Jul 17, 2015 · 0 comments

Comments

@emilsoman
Copy link
Contributor

Protocol versions have a major and minor version. Major versions are bumped when the protocol format has breaking changes. Minor versions are bumped when protocol has additions, like new messages or new commands, but existing clients need not worry about breaking changes. A client running on protocol version 2.0 should still work fine with a server with protocol version 2.1.

But currently the client does only a simple equality comparison of the whole protocol version, ie, it checks if "2.0" == "2.1" and fails. We should change it to the following:

Do not fail if :

  1. Major protocol version numbers of both are same
  2. Minor protocol version of server >= minor protocol version of client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant