Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this gem maintained? #52

Open
bibstha opened this issue Feb 13, 2018 · 11 comments
Open

Is this gem maintained? #52

bibstha opened this issue Feb 13, 2018 · 11 comments
Labels

Comments

@bibstha
Copy link

bibstha commented Feb 13, 2018

Looking for some invoicing gems and this one looks like it has good documentation.
But the last commit is in 2015. So curious if there are any forks maintained or do you guys plan to support this still?

@iffyuva
Copy link
Member

iffyuva commented Feb 13, 2018

@bibstha no time unfortunately. If you have proper use case, let me know. We can support it.

@bibstha
Copy link
Author

bibstha commented Feb 13, 2018

Does it at least run on Rails5? I like the concepts mentioned in the documentation and would love to see it atleast compatible with Rails 5.1.

@iffyuva
Copy link
Member

iffyuva commented Feb 14, 2018

We can land this support @bibstha . Give us this weekend.

@etcook
Copy link

etcook commented Sep 27, 2018

I, myself, came here looking for an invoicing solution for Rails 5.2. Would love to lend some dev time to assist as well, if necessary.

@weber-s
Copy link

weber-s commented Oct 4, 2020

Hello,

I am reviving this issue. Apparently there is almost everything ready for rails5 with the PR #83 and the branch of @thegeorgeous https://github.com/code-mancers/invoicing/tree/update-ruby-rails-versions .

I am relying on this gem for a non-profit Internet Service provider invoicing logic, and we need to move on rails5 now. Invoicing is the only gem that limit the upgrade right now. I really think this gem is a very nice one and having a release on rubygem that support rails 5.2 would be really great!

Any news on it?

@etcook
Copy link

etcook commented Oct 4, 2020

We're actively using it on Rails 6, if that means anything to you.

@etcook
Copy link

etcook commented Oct 8, 2020

@weber-s I have a fork where I've compiled some network changes into one which allow for usage on rails >= 5. It needs to be tested some more, but it's operational in a production environment. Admittedly we're only using a fraction of the capabilities, though, so not sure as to coverage.

https://github.com/etcio/invoicing/

@iffyuva
Copy link
Member

iffyuva commented Oct 9, 2020

@etcook can you please open a PR, I will merge it and do a release?

@etcook
Copy link

etcook commented Oct 9, 2020

@iffyuva Actually, I just attempted to do a PR and it looks like after a merge with your master, the two are actually now in parity. So we're effectively using your master in production right now.

While I have your attention, I'd like to do some functional PRs, especially around support for UUIDs and automatically recalculating totals, etc. Will these be accepted?

@iffyuva
Copy link
Member

iffyuva commented Oct 9, 2020

@etcook yes, definitely. Please open them so that we can discuss and merge those PRs.

@weber-s
Copy link

weber-s commented Nov 7, 2020

Hello,

Is a release on rubygem planned ? I strongly prefer using gem from here than github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants