Skip to content

Commit e571a6d

Browse files
committed
refactor: Builder 적용
1 parent eb05645 commit e571a6d

File tree

3 files changed

+33
-31
lines changed

3 files changed

+33
-31
lines changed
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package com.sprint.mission.discodeit.dto.User;
22

33
import java.util.UUID;
4+
import lombok.Builder;
45

6+
@Builder
57
public record UserResponse(
68
UUID id,
79
String username,
810
String email,
911
boolean isOnline,
10-
boolean profileImage
12+
boolean hasProfileImage
1113
) {
1214
}

src/main/java/com/sprint/mission/discodeit/service/basic/BasicChannelService.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -59,23 +59,23 @@ public ChannelResponse find(ChannelFindRequest request) {
5959
.toList();
6060

6161
if (channel.getType().equals(ChannelType.PUBLIC)) {
62-
return new ChannelResponse(
63-
channel.getId(),
64-
channel.getType(),
65-
channel.getName(),
66-
channel.getDescription(),
67-
recentMessageAt,
68-
null
69-
);
62+
return ChannelResponse.builder()
63+
.id(channel.getId())
64+
.type(channel.getType())
65+
.name(channel.getName())
66+
.description(channel.getDescription())
67+
.lastMessageAt(recentMessageAt)
68+
.participantIds(null)
69+
.build();
7070
} else {
71-
return new ChannelResponse(
72-
channel.getId(),
73-
channel.getType(),
74-
channel.getName(),
75-
channel.getDescription(),
76-
recentMessageAt,
77-
participantIds
78-
);
71+
return ChannelResponse.builder()
72+
.id(channel.getId())
73+
.type(channel.getType())
74+
.name(channel.getName())
75+
.description(channel.getDescription())
76+
.lastMessageAt(recentMessageAt)
77+
.participantIds(participantIds)
78+
.build();
7979
}
8080

8181
}

src/main/java/com/sprint/mission/discodeit/service/basic/BasicUserService.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,13 @@ public UserResponse find(UserFindRequest request) {
7171
.map(status -> status.getUpdatedAt().isAfter(Instant.now().minusSeconds(300)))
7272
.orElse(false);
7373

74-
return new UserResponse(
75-
user.getId(),
76-
user.getUsername(),
77-
user.getEmail(),
78-
isOnline,
79-
user.isHasProfileImage()
80-
);
74+
return UserResponse.builder()
75+
.id(user.getId())
76+
.username(user.getUsername())
77+
.email(user.getEmail())
78+
.isOnline(isOnline)
79+
.hasProfileImage(user.isHasProfileImage())
80+
.build();
8181
}
8282

8383
@Override
@@ -88,13 +88,13 @@ public List<UserResponse> findAll() {
8888
.map(status -> status.getUpdatedAt().isAfter(Instant.now().minusSeconds(300)))
8989
.orElse(false);
9090

91-
return new UserResponse(
92-
user.getId(),
93-
user.getUsername(),
94-
user.getEmail(),
95-
isOnline,
96-
user.isHasProfileImage()
97-
);
91+
return UserResponse.builder()
92+
.id(user.getId())
93+
.username(user.getUsername())
94+
.email(user.getEmail())
95+
.isOnline(isOnline)
96+
.hasProfileImage(user.isHasProfileImage())
97+
.build();
9898
})
9999
.toList();
100100
}

0 commit comments

Comments
 (0)