refactor: 분기 처리 삼항연산자, if 문 질문

Author: jaewoo9797

codeit-bootcamp-spring/1-sprint-mission/src/main/java/com/sprint/mission/discodeit/application/service/channel/JCFChannelService.java

@@ -13,6 +13,7 @@
 import com.sprint.mission.discodeit.domain.channel.enums.ChannelVisibility;
 import com.sprint.mission.discodeit.domain.channel.exception.AlreadyJoinUserException;
 import com.sprint.mission.discodeit.domain.channel.exception.ChannelNotFoundException;
+import com.sprint.mission.discodeit.domain.channel.exception.NotChannelManagerException;
 import com.sprint.mission.discodeit.domain.readStatus.ReadStatus;
 import com.sprint.mission.discodeit.domain.user.User;
 import com.sprint.mission.discodeit.global.error.ErrorCode;
@@ -115,7 +116,7 @@ public void deleteChannel(UUID userId, DeleteChannelRequestDto requestDto) {
 
     private void throwIsNotManager(User foundUser, Channel foundChannel) {
         if (!foundChannel.isManager(foundUser)) {
-            throw new IllegalArgumentException();
+            throw new NotChannelManagerException(ErrorCode.CHANNEL_ADMIN_REQUIRED, foundUser.getUsernameValue());
         }
     }
 
@@ -141,9 +142,17 @@ private void createAndSaveReadStatus(User foundUser, Channel savedChannel) {
 
     private Channel createChannelWithVisibility(UUID userId, CreateChannelRequestDto requestDto) {
         User foundUser = userService.findOneByIdOrThrow(userId);
-        Channel createChannel = requestDto.visibility() == ChannelVisibility.PUBLIC ?
-                Channel.ofPublicChannel(requestDto.name(), requestDto.channelType(), foundUser) :
-                Channel.ofPrivateChannel(foundUser, requestDto.channelType());
+        Channel createChannel = null;
+        if (requestDto.visibility() == ChannelVisibility.PUBLIC) {
+            createChannel = Channel.ofPublicChannel(requestDto.name(), requestDto.channelType(), foundUser);
+        } else if (requestDto.visibility() == ChannelVisibility.PRIVATE) {
+            createChannel = Channel.ofPrivateChannel(foundUser, requestDto.channelType());
+        }
+//        ====> 삼항 연산자와 if 문 분기처리 중 어떤 것을 더 선호해야할까요? 제가 생각하기에는 삼항 연산자가 보기 더 편한것 같습니다.
+//        다음 미션에서는 둘 중 하나 지워두겠습니다.
+//        createChannel = requestDto.visibility() == ChannelVisibility.PUBLIC ?
+//                Channel.ofPublicChannel(requestDto.name(), requestDto.channelType(), foundUser) :
+//                Channel.ofPrivateChannel(foundUser, requestDto.channelType());
         Channel savedChannel = channelRepository.save(createChannel);
         createAndSaveReadStatus(foundUser, savedChannel);
         return savedChannel;

codeit-bootcamp-spring/1-sprint-mission/src/main/java/com/sprint/mission/discodeit/domain/channel/exception/NotChannelManagerException.java

@@ -0,0 +1,11 @@
+package com.sprint.mission.discodeit.domain.channel.exception;
+
+import com.sprint.mission.discodeit.global.error.ErrorCode;
+import com.sprint.mission.discodeit.global.error.exception.InvalidException;
+
+public class NotChannelManagerException extends InvalidException {
+
+    public NotChannelManagerException(ErrorCode errorCode, String message) {
+        super(errorCode, message);
+    }
+}

codeit-bootcamp-spring/1-sprint-mission/src/main/java/com/sprint/mission/discodeit/global/error/ErrorCode.java

@@ -30,6 +30,8 @@ public enum ErrorCode {
     // Channel
     INVALID_CHANNEL_NAME_NOT_NULL(400, "채널 이름은 필수 입력값 입니다."),
     ALREADY_CHANNEL_JOIN_USER(400, "이미 참여한 채널입니다."),
+    CHANNEL_ADMIN_REQUIRED(400, "채널 삭제가 허용되지 않은 사용자입니다."),
+
     // Message
     INVALID_MESSAGE_CONTENT_NOT_NULL(400, "메시지 내용은 필수 입력값 입니다."),
     ;